Repository navigation
Nan reasons reweight test - #1
Merged
Merged
Conversation
…g path - summary.csv: geom_status, lag1_status, reweight_status, stitch_status explain every NaN (too_few_bins, too_few_pairs, constant_cycles, no_root, low_neff, cv_ge_1_at_lambda0, empty_pool, no_pass, ok_pool_fallback) - lag-1 correlation no longer computed on constant input - tests/synthetic.py + test_reweight_path.py: hand-built data where the weighted CV crosses 1, exercising finite lambda*, bootstrap CI, N_eff, KS at lambda*, and TSE weights (ratio c^3) end to end - regtest: checks every NaN has a reason code and compares reason codes; reference regenerated (only the four status columns added, no value changes) - README: status table and test description
- notebooks/demo.ipynb: attempts vs Q‡, reweighting weights/saturation/CV/N_eff, stitching and emergence of Poisson statistics, validation against a simulated higher barrier (foot vs top of the barrier), joint-mode checks; ipywidgets sliders when available, static figures otherwise (MAXCAL_DEMO_STATIC=1 for the committed, GitHub-readable copy) - maxcal_poisson/maxcal_joint: set the Agg backend in main() instead of at import, so the modules can be imported in notebooks - tests/test_notebook.py (slow): notebook executes top to bottom - pyproject: 'demo' extra (jupyterlab, ipywidgets); notebook deps in 'test' - CI runs the notebook test; README documents the demo
csv.writer defaults to CRLF, which made tests/regtest/reference_summary.csv CRLF-terminated; git am strips CRs from patches by default, so patches touching that file failed to apply. All CSVs are now written with '\n', the reference is regenerated (content unchanged apart from line endings), and .gitattributes normalises text files to LF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.