Repository navigation
cmdata: cross interactions bug and hydrogen atoms handling - #671
Merged
Merged
Conversation
Member
Author
|
one more issue is the multi-threading was and still is buggy for cross interactions, again for the CDF calculation that is wrong when using multi-threading. I am thinking of removing multi-threading for the moment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brunostega @frantropy
claude found a bug in CMDATA when calculating cross intereactions CDF (the distances were correct despite the bug)
(claude could not fix it tough, c++ is far more complex than python)
in addition now H and HN atoms are handled automatically