Skip to content

cmdata: cross interactions bug and hydrogen atoms handling - #671

Merged
carlocamilloni merged 4 commits into
multi-ego:mainfrom
carlocamilloni:main
Apr 13, 2026
Merged

carlocamilloni merged 4 commits into
multi-ego:mainfrom
carlocamilloni:main

Conversation

@carlocamilloni

Copy link
Copy Markdown
Member

@brunostega @frantropy
claude found a bug in CMDATA when calculating cross intereactions CDF (the distances were correct despite the bug)
(claude could not fix it tough, c++ is far more complex than python)

in addition now H and HN atoms are handled automatically

@carlocamilloni

Copy link
Copy Markdown
Member Author

one more issue is the multi-threading was and still is buggy for cross interactions, again for the CDF calculation that is wrong when using multi-threading. I am thinking of removing multi-threading for the moment

@carlocamilloni
carlocamilloni merged commit 8e70506 into multi-ego:main Apr 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant