Repository navigation
Update the muscle tester - #422
Merged
Merged
Conversation
LourensVeen
requested changes
Oct 6, 2026
LourensVeen
left a comment
LourensVeen
left a comment
Contributor
There was a problem hiding this comment.
This works, but I found it a bit too difficult to understand. I've left some comments on improving structure and naming. Thanks!
LourensVeen
approved these changes
Oct 9, 2026
LourensVeen
left a comment
LourensVeen
left a comment
Contributor
There was a problem hiding this comment.
Very nice work, this is much clearer now. Let's get it merged, and then we just need the timeline bridge and can get this all out there 😄.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single component can’t sit both above the implementation and alongside it after the timeline changes, so using one tester component with only
O_I/Sports didn’t work.The fix: two tester components
F_INITandO_Fports. If there are noF_INITports, it drives the implementation’s reuse loop throughmuscle_settings_in.O_IandSports, similar to aninteractcoupling, with matching timelines declared. It is only added when the implementation hasO_IorSports. The parent nests it throughmuscle_settings_in, so it sits at the same timeline level as the implementation.Note: From the user’s perspective, nothing changes.