Repository navigation
Fix bug: If the callee is never called. - #423
Merged
Merged
Conversation
LourensVeen
requested changes
Oct 12, 2026
LourensVeen
left a comment
LourensVeen
left a comment
Contributor
There was a problem hiding this comment.
I've looked at it and I agree that this is the right solution. We do have a failing C++ test that needs to be fixed, and if the Python one could be improved a bit as indicated then this is good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a caller never calls a component during a run, for example because the component is optional, that component used to crash. On its first run,
reuse_instance()returnedTrueeven though its F_INIT ports had closed without a message. Nowreuse_instance()only runs the first iteration without an F_INIT message if the component has no F_INIT ports at all. A component that has F_INIT ports but is never called shuts down cleanly.