Repository navigation
docs(component): correct three statements made stale by later rules - #171
Merged
Merged
Conversation
The security paragraph's "both values" predates the email and name headers, and two diagnostics rows described only part of what raises them: ERR_ENDPOINT_NOT_HTTP also covers public URL and hostname reads (COMP-EP-004), and ERR_UNKNOWN_INPUT_REFERENCE also covers a member on a value input (COMP-OUT-004). Refs #166 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Justin Merrell <merrelljustin@gmail.com>
justinmerrell
force-pushed
the
docs/component-prose-166
branch
from
October 4, 2026 05:32
9722eb5 to
c2cf8cb
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #166.
What changes
Three prose corrections in component v1. None changes what validates.
viewerIdentityHeaderandtrustedProxyCIDRs(feat(blueprint): authenticated exposure with forwarded viewer identity #135). feat(core): identity modes, machine access, installer facts and hashes #145 added the email and name headers and a sentence in between, so "both values" no longer had a clear antecedent. It now names the header names andtrustedProxyCIDRs.ERR_ENDPOINT_NOT_HTTP. The row said "HTTP operation or viewer identity property". COMP-EP-004 also raises it forpublicURLandpublicHostnameon a non-HTTP endpoint (semantic/044).ERR_UNKNOWN_INPUT_REFERENCE. The row covered a connection input withoutmember, but not a value input with one. COMP-OUT-004 raises it for both (semantic/028,semantic/029).Why
#166 (S1) needs component 1.6.1 cut through the post-ADR 0037
release.yml, so that its archive carries the conventionsrelease.jsonandspecification.json, and the release carriesSHA256SUMS. component 1.6.0 predates #164, and nothing has changed in component since. Thisdocscommit is a genuine correction that also triggers the patch.Merge order: after core 1.1.1 is published, so that its release entry records that core edition. The blueprint PR follows this one's release.
Compatibility
Checks
A local
task checkreachedcheck:compatwith no failures before it hit a time limit, and the branch was pushed with--no-verify. CI is the authority.🤖 Generated with Claude Code