Repository navigation
Show moderation rejection messages in the chat UI - #1746
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat moderation requests were started without awaiting or catching failures, so backend rejections—including the
failed-preconditionresponses added in #1745—never reached the user.Await ban, unban, timeout, and delete requests for both Twitch and Kick, then display the callable error's message in a snackbar. Close dialogs before sending requests and retain the page's ScaffoldMessenger so delayed failures remain visible after the original message disappears; safely ignore results after the page is disposed. Cancelling either dialog makes no request.
Validation: all 586 Flutter tests pass;
flutter analyzepasses. Widget tests cover all four failed actions on both providers, delayed failures after message removal or page disposal, dialog cancellation, and successful account routing.