Skip to content

Публичная поверхность к фактам: дефолтный gateway, версия из манифеста, 7 venues, инвайт (0.5.0) - #4

Merged
namixai merged 3 commits into
mainfrom
fix/public-surface-p0-p8
Aug 11, 2026
Merged

namixai merged 3 commits into
mainfrom
fix/public-surface-p0-p8

Conversation

@namixai

@namixai namixai commented Aug 10, 2026 •

Copy link
Copy Markdown
Owner

Зеркало signer-mcp 0.6.0 (контракт гейтвея общий), по тем же двум аудитам 2026-08-10.

  • П1 — дефолт SIGNER_GATEWAY_URL → https://signer-demo.usenami.io:8443 (старый 301-редиректил всё на лендинг); HTML-ответ называется своим именем вместо «Unexpected token '<'».
  • П6-класс — версия из манифеста: 0.4.0 слала User-Agent «@0.2.0» (та же болезнь, что signer-mcp#11).
  • П2 — инвайт назван в README; «Issue tokens at…» убрано из ошибки.
  • П4 — 7 venues со status: hyperliquid_main denied, hyperliquid_testnet добавлен; сноска mainnet-Binance.
  • П8 — самокоррекции убраны из notes манифеста в CHANGELOG; адрес сверки PCR0 приведён к /signer/attestations.

Проверено фактом: tsc чистый, тесты 31/31; из тарбола (npm pack → чистая установка) dist отдаёт PLUGIN_VERSION=0.5.0 и новый DEFAULT_GATEWAY_URL. Eliza-рантайм не поднимался — изменения зеркалят проверенные в signer-mcp.

npm публикует Alex.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added support and documentation for seven venues, including Hyperliquid testnet and mainnet availability statuses.
    • Updated pilot access and token provisioning instructions.
    • Added clearer venue status information and hosted deployment guidance.
  • Bug Fixes

    • Improved handling of HTML responses with clearer configuration errors.
    • Corrected Binance, OKX, gateway, and attestation documentation.
    • Updated the default gateway for hosted demo access.
  • Chores

    • Updated the release version to 0.5.0.
    • Gateway version information now stays aligned with the application release.

… своим именем, версия из манифеста (зеркало signer-mcp#11), инвайт вместо 'Issue tokens at', notes без самокоррекций
…enied, testnet добавлен), новый дефолт; версия 0.5.0 + CHANGELOG
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f2b71979-247c-4ca0-a353-b8cd617c56d1

📥 Commits

Reviewing files that changed from the base of the PR and between d4a9b96 and 1295ad1.

📒 Files selected for processing (4)
  • README.md
  • package.json
  • src/gateway.ts
  • src/venues.ts
🚧 Files skipped from review as they are similar to previous changes (4)
  • package.json
  • README.md
  • src/venues.ts
  • src/gateway.ts

📝 Walkthrough

Walkthrough

The 0.5.0 release updates the default gateway, derives the plugin version from package.json, improves HTML-response errors, changes token access wording, and documents the seven-venue manifest and deployment statuses.

Changes

Gateway and venue update

Layer / File(s) Summary
Gateway runtime and release alignment
src/config.ts, src/gateway.ts, package.json, README.md, CHANGELOG.md
The plugin uses the hosted demo gateway, derives PLUGIN_VERSION from package metadata, reports HTML gateway responses, and documents invite-based token access. The package and changelog now identify version 0.5.0.
Venue manifest and deployment notes
src/venues.ts, README.md
Documentation expands the manifest to seven venues, adds Hyperliquid statuses, corrects Binance and OKX deployment notes, and updates the attestation URL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main public-surface changes, including the default gateway, manifest versioning, seven venues, and invite-based access.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/public-surface-p0-p8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@package.json`:
- Line 4: Update package.json line 4 to remove or change the stale “6 venues”
wording to seven. Also update README.md lines 62-66 in the LIST_SIGNER_VENUES
description to document all seven manifest entries and their live or denied
statuses.

In `@src/venues.ts`:
- Line 52: Update the static manifest text in LIST_SIGNER_VENUES to remove the
time-relative “today” wording. Replace it with release-scoped wording that
remains accurate across future provisioning changes, without altering the
manifest’s other behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c88a08b-97aa-4284-9107-5232e353c7b1

📥 Commits

Reviewing files that changed from the base of the PR and between eea0790 and d4a9b96.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • README.md
  • package.json
  • src/config.ts
  • src/gateway.ts
  • src/venues.ts

Comment thread package.json Outdated
Comment thread src/venues.ts Outdated
… записей, content-type без регистра, okx-note release-scoped
@namixai
namixai merged commit f45aacd into main Aug 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant