Skip to content

Suggest to loosen the dependency on pkuseg #4

Description

@Agnes-U

Hi, your project BulidDataset requires "pkuseg==0.0.25" in its dependency. After analyzing the source code, we found that some other versions of pkuseg can also be suitable without affecting your project, i.e., pkuseg 0.0.21, 0.0.22. Therefore, we suggest to loosen the dependency on pkuseg from "pkuseg==0.0.25" to "pkuseg>=0.0.21,<=0.0.25" to avoid any possible conflict for importing more packages or for downstream projects that may use BulidDataset.

May I pull a request to loosen the dependency on pkuseg?

By the way, could you please tell us whether such dependency analysis may be potentially helpful for maintaining dependencies easier during your development?



For your reference, here are details in our analysis.

Your project BulidDataset(commit id: 3550a64) directly uses 1 APIs from package pkuseg.

pkuseg.__init__.pkuseg.__init__

From which, 35 functions are then indirectly called, including 12 pkuseg's internal APIs and 23 outsider APIs, as follows (neglecting some repeated function occurrences).

[/napoler/BulidDataset]
+--pkuseg.__init__.pkuseg.__init__

We scan pkuseg's versions among [0.0.21, 0.0.22] and 0.0.25, the changing functions (diffs being listed below) have none intersection with any function or API we mentioned above (either directly or indirectly called by this project).

diff: 0.0.25(original) 0.0.21
['pkuseg.__init__.pkuseg', 'pkuseg.__init__.TrieNode', 'pkuseg.__init__.pkuseg.cut', 'pkuseg.__init__.Preprocesser.__init__', 'pkuseg.__init__.Preprocesser.solve', 'pkuseg.__init__.Preprocesser', 'pkuseg.__init__.Preprocesser.insert', 'pkuseg.__init__.TrieNode.__init__']

diff: 0.0.25(original) 0.0.22
[](no clear difference between the source codes of two versions)

As for other packages, the APIs of @outside_package_name are called by pkuseg in the call graph and the dependencies on these packages also stay the same in our suggested versions, thus avoiding any outside conflict.

Therefore, we believe that it is quite safe to loose your dependency on pkuseg from "pkuseg==0.0.25" to "pkuseg>=0.0.21,<=0.0.25". This will improve the applicability of BulidDataset and reduce the possibility of any further dependency conflict with other projects/packages.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions