Switch to slog - #317
Open
lucacome wants to merge 1 commit into
Open
Switch to slog#317lucacome wants to merge 1 commit into
lucacome wants to merge 1 commit into
Conversation
Owner
|
Thanks @lucacome, this is a generous contribution. I'm sorry I didn't get around to looking at it until now. Part of the issue is that it's a bunch of unrelated changes. Would you mind splitting it into at least two PRs - one for the dependency updates/configuration/build stuff, and one for the Go changes? Ideally I'd like to see the kingpin change in its own PR too, as that's the one I'm least certain I want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and improvements across multiple files, focusing on upgrading dependencies, enhancing logging, and refactoring code for better readability and maintainability. Below are the most important changes grouped by theme:
Dependency Upgrades:
actions/setup-goaction to version 5 and set the Go version tostablein.github/workflows/build.ymland.github/workflows/release.yml. [1] [2]goreleaser/goreleaser-actionto version 6 in.github/workflows/release.yml.Configuration and Build:
.golangci.ymlto enable specific linters and set exclusion rules for test files.Makefileto use the-trimpathflag in thebuildtarget and upgraded the Go version indockertestanddockerintegtargets. [1] [2]Logging Enhancements:
logpackage withlog/slogfor structured logging incmd/process-exporter/main.goandcollector/process_collector.go. [1] [2]cmd/process-exporter/main.go. [1] [2]Code Refactoring:
cmd/process-exporter/main.goto usekingpinfor better command-line argument parsing.ioutil.TempFileandioutil.ReadFilewithos.CreateTempandos.ReadFilerespectively incmd/load-generator/main.goandconfig/config.go. [1] [2]Miscellaneous:
//go:build linuxtocmd/load-generator/main.gofor specifying the target operating system.cmd/integration-tester/main.go. [1] [2]These changes collectively aim to modernize the codebase, improve logging, and ensure compatibility with the latest tools and dependencies.