Conversation
…itor BIC SEPATransfer::addCreditor() groups the creditors by their reqestedExecutionDate, but toXML() always wrote the literal 1999-01-01 (the FinTS marker for "execute now"), so a scheduled transfer was impossible and the date given in the test was ignored. Write the group's date when it lies in the future; dates up to today keep emitting 1999-01-01 so immediate transfers over FinTS (HKCCS/HKCCM) behave as before. The pain.001.001.09 branch compared against the wrong string and produced an invalid <addChild> element; it now emits <ReqdExctnDt><Dt>...</Dt></ReqdExctnDt>. SEPACreditor::XMLTransfer() always wrote <CdtrAgt><FinInstnId><BIC/> even when no BIC was given, which banks reject. CdtrAgt is optional since IBAN-only, so omit it when the BIC is empty (spaces are stripped like in XMLDirectDebit()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SEPATransfer::addCreditor()groups the creditors by theirreqestedExecutionDate, buttoXML()always wrote the literal1999-01-01(the FinTS marker for "execute now"). A scheduled transfer (Terminüberweisung, HKCSE/HKCME over FinTS) was therefore impossible, and the date the bundled test passes (P1D) was silently ignored. Thepain.001.001.09branch additionally compared against the wrong string ('001.001.09') and produced an invalid<addChild>element.SEPACreditor::XMLTransfer()always wrote<CdtrAgt><FinInstnId><BIC/>even when no BIC was given, which banks reject;CdtrAgtis optional since IBAN-only.Both of our applications override
toXML()in a subclass for exactly these two reasons (Volksbank/Atruvia and Sparkasse via nemiah/php-fints).Change
1999-01-01, so immediate transfers over FinTS (HKCCS/HKCCM) behave exactly as before.pain.001.001.09emits<ReqdExctnDt><Dt>…</Dt></ReqdExctnDt>.CdtrAgtwhen the BIC is empty (spaces stripped like inXMLDirectDebit()).Verified by generating pain.001.001.03 documents for tomorrow / today / an empty BIC and for
pain.001.001.09.Note on authorship
Developed with AI assistance (Cursor) and reviewed by the submitting human; the vouching statement per nemiah/phpFinTS#586 will be added by the author once the review is complete.