Skip to content

ci: keep a CI run for every push and fix the Windows source-key test - #11

Open
zzstar101 wants to merge 2 commits into
mainfrom
fix/ci-concurrency-windows
Open

zzstar101 wants to merge 2 commits into
mainfrom
fix/ci-concurrency-windows

Conversation

@zzstar101

Copy link
Copy Markdown
Collaborator

Summary

  • Give every pushed commit its own CI concurrency group. GitHub keeps at most one running and one pending run per group; with a branch-only group, a burst of merges replaces the pending run and cancels that commit before any job starts (e.g. run #62 / d82e079). Pull requests still share one group per PR so stale PR runs are cancelled.
  • Skip the Unix 0600 mode assertion for the source-key file on Windows. Windows has no Unix permission bits; os.Chmod only controls the read-only flag and os.Stat reports 0666. The key still lives under the per-user data directory and inherits its ACL.

Validation

  • GOARCH=amd64 go test ./internal/app -count=1 passes on Windows.
  • GOARCH=amd64 go test ./internal/app -run '^TestSourceKeyLivesOutsideTheIndex$' -count=1 passes.
  • CI workflow YAML parses; trigger/jobs unchanged.
  • git diff --check passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant