chore(scripts): use portable Bash shebangs - #3501
Merged
Merged
Conversation
Collaborator
Author
|
@chenyukang Ready to merge. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates executable project shell scripts to use a more portable Bash shebang (#!/usr/bin/env bash) instead of assuming Bash lives at /bin/bash, improving compatibility across environments while keeping existing script logic unchanged.
Changes:
- Replaced
#!/bin/bashwith#!/usr/bin/env bashin the project’s release/packaging helper scripts. - Ensured scripts invoked directly in CI (e.g.,
./scripts/download-ckb.sh ...) still have a valid Bash interpreter resolution viaenv.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/release.sh | Switch shebang to /usr/bin/env bash for portability. |
| scripts/package-for-test.sh | Switch shebang to /usr/bin/env bash for portability. |
| scripts/download-ckb.sh | Switch shebang to /usr/bin/env bash for portability. |
| scripts/copy-ui-files.sh | Switch shebang to /usr/bin/env bash for portability. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chenyukang
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/usr/bin/envin all executable project shell scripts/bin/bashTesting
bash -n scripts/copy-ui-files.sh scripts/download-ckb.sh scripts/package-for-test.sh scripts/release.sh#!/bin/bashshebangs remain in the repositorygit diff --check origin/develop...HEAD