Skip to content

chore(scripts): use portable Bash shebangs - #3501

Merged
chenyukang merged 1 commit into
developfrom
chore/env-bash-shebangs
Aug 24, 2026
Merged

chore(scripts): use portable Bash shebangs#3501
chenyukang merged 1 commit into
developfrom
chore/env-bash-shebangs

Conversation

@eval-exec

Copy link
Copy Markdown
Collaborator

Summary

  • resolve Bash through /usr/bin/env in all executable project shell scripts
  • avoid assuming Bash is installed at /bin/bash
  • preserve existing script behavior and executable modes

Testing

  • bash -n scripts/copy-ui-files.sh scripts/download-ckb.sh scripts/package-for-test.sh scripts/release.sh
  • verified no exact #!/bin/bash shebangs remain in the repository
  • git diff --check origin/develop...HEAD

Copilot AI lite review requested due to automatic review settings August 24, 2026 08:14
@eval-exec

Copy link
Copy Markdown
Collaborator Author

@chenyukang Ready to merge.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates executable project shell scripts to use a more portable Bash shebang (#!/usr/bin/env bash) instead of assuming Bash lives at /bin/bash, improving compatibility across environments while keeping existing script logic unchanged.

Changes:

  • Replaced #!/bin/bash with #!/usr/bin/env bash in the project’s release/packaging helper scripts.
  • Ensured scripts invoked directly in CI (e.g., ./scripts/download-ckb.sh ...) still have a valid Bash interpreter resolution via env.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/release.sh Switch shebang to /usr/bin/env bash for portability.
scripts/package-for-test.sh Switch shebang to /usr/bin/env bash for portability.
scripts/download-ckb.sh Switch shebang to /usr/bin/env bash for portability.
scripts/copy-ui-files.sh Switch shebang to /usr/bin/env bash for portability.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chenyukang
chenyukang merged commit 3ab79fa into develop Aug 24, 2026
25 checks passed
@chenyukang
chenyukang deleted the chore/env-bash-shebangs branch August 24, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants