[NAE-2466] Advanced search for PFQL - #352
Open
Retoocs wants to merge 56 commits into
Open
Conversation
- add todos
- update advanced search to use PFQL query
- fix tests - fix code according to tests
- update tests with some pfql queries
- update operator is-null to work with PFQL
- remove categories that are impossible to use with PFQL
- update like operator to work with PFQL
- fix tests
- add antlr dependency and PFQL grammar
- add parser models
- implement mechanism to parse string PFQL query into advanced search - add todos
- update parser: implement handling for more case categories
- implement handling for CaseDataSet category
- implement handling for CaseDataSet category
- implement handling for task categories
- add documentation - resolve some todos - handle logged user placeholders
- implement negations for simple expressions
- implement negations for complex expressions
- fix negations in complex-expression.ts - fix reducing complex expressions in pfql-utils.ts
- fix handling simple ORs - fix await for category loadings
- flat query items if the boolean operator is the same as parent predicate's boolean operator
- add docs
- fix redundant requests to BE when initializing advanced search
- fix race condition when loading dataset category from pfql
- remove push down negation
- remove OR operator button
- introduce plain query category
- implement loading of plain query
- implement possibility to show filter field as advanced search in form - change default component of filter to string-query
- update CaseProcess category so when used in form there is no autocomplete
- remove filter metadata implementation - update advanced search immediate field representation - fix process identifier column search - resolve some todos
- fix tests
Retoocs
requested review from
Kovy95,
SamuelPalaj,
machacjozef,
mazarijuraj,
renczesstefan and
tuplle
August 31, 2026 14:04
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- fix tests
- add search service test
- remove unwanted import
# Conflicts: # projects/netgrif-components-core/src/lib/header/case-header/case-header.service.ts
- fix after merge
Retoocs
marked this pull request as ready for review
September 1, 2026 19:35
- rework dependency injection for PFQL components
- fix tests
- update maximumError to 6.5 MB
- fix behavior for advanced search field content
- fix tests
- fix missing provider
- fix missing token - fix case dataset as immediate field
- fix tests
Kovy95
reviewed
Sep 10, 2026
| "help": { | ||
| "title": "Nápoveda pre rozšírené vyhľadávanie", | ||
| "text": "Rozšírené vyhľadávanie slúži na zostavenie komplikovanejších požiadaviek na vyhľadávanie. Na začiatku zvoľte kategóriu vyhľadávania. Kategória vyhľadávania učruje, podľa čoho má váš dopyt vyhľadávať. Niektoré kategórie, ako napríklad \"Dáta prípadu\" vyžadujú dodatočnú konfiguráciu. Po zvolení kategórie je nutné zvoliť operátor vyhľadávania. Operátor rozhoduje o tom, akým spôsobom sa hľadá zhoda s hľadaným výtazom a dátami. Operátorom je možné hľadať napríklad presnú zhodu, alebo hodnotu z rozsahu. Nakoniec je nutné zadať hľadanú hodnotu. Dopyty je možné kombinovať pomocou kľúčových slov A SÚČASNE a ALEBO. Dopyty kombinované slovom ALEBO nájdu výsledky, spĺňajúce aspoň jednu z podmienok. Dopyty kombinované slovom A SÚČASNE nájdu výsledky spĺňajúce všetky podmienky." | ||
| "text": "Rozšírené vyhľadávanie slúži na zostavenie komplikovanejších požiadaviek na vyhľadávanie. Na začiatku zvoľte kategóriu vyhľadávania. Kategória vyhľadávania určuje, podľa čoho má váš dopyt vyhľadávať. Niektoré kategórie, ako napríklad \"Dáta prípadu\" vyžadujú dodatočnú konfiguráciu. Po zvolení kategórie je nutné zvoliť operátor vyhľadávania. Operátor rozhoduje o tom, akým spôsobom sa hľadá zhoda s hľadaným výrazom a dátami. Operátorom je možné hľadať napríklad presnú zhodu, alebo hodnotu z rozsahu. Nakoniec je nutné zadať hľadanú hodnotu. Dopyty je možné kombinovať pomocou kľúčových slov A SÚČASNE. Dopyty kombinované slovom A SÚČASNE nájdu výsledky spĺňajúce všetky podmienky. If you wish to enter more complex queries you can select plain query category and enter any valid PFQL query. Ak potrebujete zadať komplexnejší dopyt, môžete zvoliť kategóriu 'Obyčajný dopyt', kde viete napísať ľubovoľný platný PFQL dopyt." |
Contributor
There was a problem hiding this comment.
part of the sentence is in english, remove it
Kovy95
reviewed
Sep 10, 2026
| export class ComplexExpression implements QueryItemInterface { | ||
| protected _items: QueryItem[]; | ||
|
|
||
| public constructor(items: QueryItem[]) { |
Contributor
There was a problem hiding this comment.
it should be optional parameter
- resolve PR comments
Kovy95
reviewed
Sep 10, 2026
| "angular-resizable-element": "~7.0.0", | ||
| "angular-resize-event": "~3.2.0", | ||
| "angular2-hotkeys": "~16.0.0", | ||
| "antlr4ng": "^3.0.16", |
Contributor
There was a problem hiding this comment.
is this one also a prerequisity for netgrif/components or components-core? or just for project ?
Contributor
Author
There was a problem hiding this comment.
Good point. The dependency is used in core. I'm going to check if the dependency should be defined in core or in components. The definition should not be here on project level
Contributor
Author
There was a problem hiding this comment.
I moved the antlr4ng dependency to core package.json. The new dev dependency I'm going to keep here
- move antlr dependency to core
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvements
Fixed
Implements NAE-2466
Dependencies
"antlr4ng": "^3.0.16",Third party dependencies
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
Manually and by unit tests
Test Configuration
Checklist: