Fixed Arista EOS reboots not being detected when waiting for the device to reload#407
Open
Defiantearth wants to merge 4 commits into
Open
Fixed Arista EOS reboots not being detected when waiting for the device to reload#407Defiantearth wants to merge 4 commits into
Defiantearth wants to merge 4 commits into
Conversation
Defiantearth
requested review from
jeffkala,
pke11y and
pszulczewski
as code owners
July 21, 2026 15:18
Defiantearth
commented
Jul 21, 2026
| return f"{days:02d}:{hours:02d}:{mins:02d}:{seconds:02d}" | ||
|
|
||
| def _wait_for_device_reboot(self, timeout=3600): | ||
| def _wait_for_device_reboot(self, original_boot_time, timeout=DEFAULT_REBOOT_TIMEOUT): |
Contributor
Author
There was a problem hiding this comment.
Using boot time instead of uptime here for the case where a devices has a uptime of 30 sec upgrades then takes a few min such that the uptime is greater then 30 sec when the api is ready which will result in a timeout.
Defiantearth
commented
Jul 21, 2026
| log.info("Host %s: OS image %s boot options set. Reboot the device to apply", self.host, image_name) | ||
| return True | ||
| self.reboot() | ||
| self._wait_for_device_reboot(timeout=timeout) |
Contributor
Author
There was a problem hiding this comment.
This was already in reboot() So as long as we pass in the timeout and wait_for_reload=True we can remove the call here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NAPPS-1413
What's Changed
Bug in OS upgrades found where when upgrading a device pyntc would return in
_wait_for_device_reboot()before the device actually rebooted.Screenshot Before(From OS Upgrades without file transfer to speed up the process of testing):
Note: You can see
Checking for reachability. This is OS Upgrades taking over waiting for the device to come back up since pyntc returned before the device came back up.Aft