fix(api): default option type to choice for non-grid questions

[josefbehr]

The problem

Creating an option through the API without an optionType stores it with a null type:

POST /ocs/v2.php/apps/forms/api/v3/forms/{formId}/questions/{questionId}/options
{"optionTexts": ["Yes", "No"]}

The options are saved and returned by the API, but the frontend does not render them. The question then appears with no selectable answers. If it is a required question, the form cannot be submitted at all. Verified on Nextcloud 32.0.9 / Forms 5.3.3 with multiple_unique questions: the options existed in GET .../forms/{id} but the rendered form showed an empty question.

This is easy to hit because optionType is documented as optional, and the failure is silent: no error, options present in the API response, just not rendered.

Why 'choice' is the right default

• The option_type migration (Version050300Date20250914000000) already backfills existing null types to 'choice'.
• DataStructure.md states: "choice is the default for normal option lists."

So 'choice' is already the documented and migrated default. newOption() simply never applied it to new inserts, so options created after the migration slip through with a null type again.

The fix

Default optionType to 'choice' for any non-grid question when the caller omits it. Grid questions are deliberately left untouched, since their options require an explicit row/column type. Adds the missing Option::OPTION_TYPE_CHOICE constant next to the existing OPTION_TYPE_ROW / OPTION_TYPE_COLUMN.

The existing integration test testCreateNewOption asserted optionType => null, which codified the broken behaviour; updated to expect 'choice'.

Context

Found while building a feedback form entirely through the API. optionType was omitted on two multiple_unique questions, and both rendered without any options.

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/Migration/Version050300Date20260716000000.php	0.00%	17 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Chartman123]

Please fix the workflows and see my comment.

BTW: please create a bug report first before creating PRs.

[josefbehr]

Applied all four suggestions in 99ea1cf: signature default 'choice', dropped the guard and the re-read, early return in the migration, and the docblock note. Thanks for the guidance.

[Chartman123]

Great, looks good now :)

[Chartman123]

/backport to stable5.3

[backportbot]

The backport to stable5.3 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable5.3
git pull origin stable5.3

# Create the new backport branch
git checkout -b backport/3504/stable5.3

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8c08c540 754d8265 f66dd9be 99ea1cf5 bbbaae96

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3504/stable5.3

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.