Added a Setting to set the Model Download Folder - #1557
Conversation
b782a1e to
796d972
Compare
There was a problem hiding this comment.
Pull request overview
Adds a configurable model download location and migrates existing models.
Changes:
- Adds model-path settings and admin UI.
- Updates model downloading and status checks.
- Adds an upgrade repair step for existing models.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
src/components/ViewAdmin.vue |
Adds model-path controls and status. |
package-lock.json |
Updates package version metadata. |
lib/Settings/AdminSettings.php |
Provides model-path status. |
lib/Service/SettingsService.php |
Defines and resolves the path setting. |
lib/Service/DownloadModelsService.php |
Downloads models to the configured location. |
lib/Migration/MoveDefaultModelFolder.php |
Migrates existing model files. |
appinfo/info.xml |
Registers the migration step. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| const SETTINGS = ['tensorflow.cores', 'tensorflow.gpu', 'tensorflow.purejs', 'imagenet.enabled', 'landmarks.enabled', 'faces.enabled', 'musicnn.enabled', 'movinet.enabled', 'node_binary', 'ffmpeg_binary', 'faces.status', 'imagenet.status', 'landmarks.status', 'movinet.status', 'musicnn.status', 'faces.lastFile', 'imagenet.lastFile', 'landmarks.lastFile', 'movinet.lastFile', 'musicnn.lastFile', 'faces.batchSize', 'imagenet.batchSize', 'landmarks.batchSize', 'movinet.batchSize', 'musicnn.batchSize', 'clusterFaces.status', 'clusterFaces.lastRun', 'nice_binary', 'nice_value', 'concurrency.enabled', 'taskprocessing.enabled'] | ||
| const SETTINGS = ['tensorflow.cores', 'tensorflow.gpu', 'tensorflow.purejs', 'imagenet.enabled', 'landmarks.enabled', 'faces.enabled', 'musicnn.enabled', 'movinet.enabled', 'node_binary', 'ffmpeg_binary', 'faces.status', 'imagenet.status', 'landmarks.status', 'movinet.status', 'musicnn.status', 'faces.lastFile', 'imagenet.lastFile', 'landmarks.lastFile', 'movinet.lastFile', 'musicnn.lastFile', 'faces.batchSize', 'imagenet.batchSize', 'landmarks.batchSize', 'movinet.batchSize', 'musicnn.batchSize', 'clusterFaces.status', 'clusterFaces.lastRun', 'nice_binary', 'nice_value', 'concurrency.enabled', 'taskprocessing.enabled', 'models_target_path', 'models_archive_file'] |
There was a problem hiding this comment.
Removing is probably not what we want though. We should add it to SettingsService
There was a problem hiding this comment.
do we really want to have separate locations for models and the archive ?
In my opinion this only increases Complexity with no Benefit right now, since the Archive already was and still will be relative to the Models folder
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@a4blue Would you be amenable to fix the above shortcomings? |
796d972 to
cc4950e
Compare
Signed-off-by: Alexander Ratajczak <a4blue@hotmail.de>
cc4950e to
fe4a9d6
Compare
This should fix #1160
In order to be compatible with existing users i added a repair step to move the old Files to the new Location
馃 AI (if applicable)