Skip to content

fix(awstf): tag topic state machines for the tagging resolver - #927

Merged
jyecusch merged 2 commits into
mainfrom
fix/awstf-topic-state-machine-tags
Oct 17, 2026
Merged

jyecusch merged 2 commits into
mainfrom
fix/awstf-topic-state-machine-tags

Conversation

@jyecusch

Copy link
Copy Markdown
Member

Follow-up to #913. Without these tags, delayed topic publishes fail on awstf with resource-resolver: tagging; matches the Pulumi provider.

@jyecusch
jyecusch requested a review from tjholm as a code owner October 17, 2026 02:00
@vercel

vercel Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
nitric-docs Ignored Ignored Preview Oct 17, 2026 2:11am UTC

Request Review

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.15%. Comparing base (a21386d) to head (46c73bb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #927      +/-   ##
==========================================
- Coverage   49.44%   46.15%   -3.30%     
==========================================
  Files          29       12      -17     
  Lines        2888     1261    -1627     
==========================================
- Hits         1428      582     -846     
+ Misses       1338      624     -714     
+ Partials      122       55      -67     
Flag Coverage Δ
aws 46.15% <ø> (+0.07%) ⬆️
azure ?
common ?
core ?
gcp ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jyecusch
jyecusch merged commit 259fce9 into main Oct 17, 2026
5 checks passed
@jyecusch
jyecusch deleted the fix/awstf-topic-state-machine-tags branch October 17, 2026 02:12
@nitric-bot

Copy link
Copy Markdown

🎉 This PR is included in version 1.28.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants