Repository navigation
[transports] Evaluate the discovery HTTP server: Issue #77 - #104
Open
Shreyavemana wants to merge 2 commits into
Open
Shreyavemana wants to merge 2 commits into
Shreyavemana wants to merge 2 commits into
Conversation
…y and port handling (nitrocloudofficial#77)
ROHIT-JR
requested changes
Nov 2, 2026
ROHIT-JR
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes: this is still the unfilled template, so the acceptance criteria on #77 aren't met yet.
- Placeholders remain throughout
docs/investigations/discovery-http-server.md(<fill in>,<list>,<path:line>,<yes/no>, and<git rev-parse --short upstream/develop>as the checked-against commit). - TypeScript consumers are not identified. The table has one placeholder row and a
TODO. If nothing outside tests consumes it, say so explicitly. - Python behaviour: the "Busy preferred port" row asks for probe output but none is pasted, and
scripts/probe_discovery_port.pyis not in the diff. Please also state which ofOAUTH_DISCOVERY_PORT/discovery_portactually applies. - Comparison table has no filled values.
- Conclusion still reads "Pick one and delete the other" with both options A and B present. Keep one; if B, link the follow-up implementation issue.
- The PR description says consumers were identified and runtime behaviour verified, but the doc contains neither.
- Minor: pin the actual commits checked, and add a trailing newline.
Please complete sections 1-4 with file:line references, then the single conclusion.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigates the TypeScript
DiscoveryHttpServerand compares it with the Python SDK's existing discovery and port-handling mechanisms.Closes #77.
Changes Made
docs/investigations/discovery-http-server.md.Tests