Repository navigation
Feature/issue 24 wire alignment - #37
Open
jpsiddharth2008 wants to merge 4 commits into
Open
jpsiddharth2008 wants to merge 4 commits into
jpsiddharth2008 wants to merge 4 commits into
Conversation
Shreyavemana
left a comment
Collaborator
There was a problem hiding this comment.
I tested the PR #37 locally and these are the results:
- The targeted tests pass (46 passed across the two test runs).
- However, the full test suite fails during collection because existing tests still import modules and functions removed by this PR:
test_mcp20_blueprint.py— missingnitrostack.transports.dispatchtest_mcp20_deprecated.py— missingnitrostack.transports.dispatchtest_mcp20_jsonrpc_wire.py— missingnitrostack.transports.dispatchtest_mcp20_stateless_http.py— cannot importbuild_ping_response
Please update or remove the affected tests as appropriate and rerun the full test suite.
4 tasks
jpsiddharth2008
force-pushed
the
feature/issue-24-wire-alignment
branch
from
October 28, 2026 13:06
e458282 to
0cc7d68
Compare
jpsiddharth2008
force-pushed
the
feature/issue-24-wire-alignment
branch
from
November 2, 2026 12:25
0cc7d68 to
166bb15
Compare
Collaborator
|
Re-checked after What this PR still adds on top of develop (verified with a TestClient probe):
Requested before merge:
Please relink this PR to #27 (#24 is being closed as superseded); the remaining items there are tracked in #27. ~sent from claude-code |
Collaborator
This was referenced Nov 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Complete the remaining MCP 2026 wire alignment for issue #24, preserving official MCP ownership of
/mcpand legacy compatibility.PRs #36 and #91 are now merged. This branch includes current
developat0d51ee4; it no longer depends on an open PR #36 branch.Changes relative to develop
resultTypeannotations across tool/resource/prompt results, preserving application metadata and special result types.Latest conflict resolution
Merged current develop with a normal merge commit, preserving history. The two conflicting files were resolved by keeping both prompt result stamping and upstream ping-handler registration, and retaining separate HTTP tests for tools-list success and modern ping rejection. Upstream visibility, stdio, widget registry, OAuth and CLI/template changes remain intact.
Verification on
c5b0427MCP 2.3.0. Complete collection: 1,252 tests. Focused wire, task, factory, HTTP ownership and stdio regression selection: 204 passed.
Linux runs include native QuickJS 1.19.4. Windows skips are the existing optional QuickJS checks (16) and symlink capability check (1). No new skips, exclusions, deselections or xfail markers were added.
The Windows failure is
test_discovery_dcr_404_when_disabled_or_missing_client_id, raisingWinError 10053. The exact same test/error reproduced on unchanged0d51ee4in the same Python/MCP environment (33 passed, 1 failed for the baseline OAuth module). OAuth source and tests are unchanged. The full Windows run is not claimed green.Hosted CI passed on Python 3.10, 3.11 and 3.12 for this exact head: run 41664166895.