Repository navigation
fix(icon-picker): border the pack filter, size by label - #293
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#292 dropped
isBlockfrom the icon pack filter so its options could size to their labels. That also removed the group's border, which the other toggle groups in the editor keep. The filter has its border back. WithisBlockalone,isAdaptiveWidthleaves the options at their label width and an empty strip at the end of the row. Each option now grows from its label width (flex: 1 1 auto), so the row is full and All stays the narrowest.On WordPress 7.2-beta1 the 288px row splits into All 59px, Ghost Kit 99px and FontAwesome 128px.