Repository navigation
[fix] Update extract_sis_data() and vignette with feedback from Jeff - #440
Open
sbreitbart-NOAA wants to merge 3 commits into
Open
sbreitbart-NOAA wants to merge 3 commits into
sbreitbart-NOAA wants to merge 3 commits into
Conversation
sbreitbart-NOAA
force-pushed
the
fix-sis-workflow
branch
from
October 27, 2026 15:17
07255bf to
958d805
Compare
sbreitbart-NOAA
marked this pull request as ready for review
November 12, 2026 18:32
sbreitbart-NOAA
force-pushed
the
fix-sis-workflow
branch
from
November 12, 2026 18:52
dbbf323 to
8e397a2
Compare
| plot_fishing_mortality(stockplotr::example_data, interactive = FALSE, make_rda = TRUE, figures_dir=savedir) | ||
| expect_no_error(extract_sis_data(sis_data_dir=savedir, key_quantities_dir=savedir, figures_tables_dir=savedir)) | ||
| plot_biomass(stockplotr::example_data, | ||
| module = "TIME_SERIES", |
Collaborator
There was a problem hiding this comment.
Suggested change
| module = "TIME_SERIES", | |
| module = "timeseries", |
I believe this is the module name for the r4ss option. I would suggest changing the example to our r4ss since this will be deprecated in time
| plot_biomass(stockplotr::example_data, module = "TIME_SERIES", interactive = FALSE, make_rda = TRUE, figures_dir=savedir) | ||
| plot_fishing_mortality(stockplotr::example_data, interactive = FALSE, make_rda = TRUE, figures_dir=savedir) | ||
| expect_no_error(extract_sis_data(sis_data_dir=savedir, key_quantities_dir=savedir, figures_tables_dir=savedir)) | ||
| plot_biomass(stockplotr::example_data, |
Collaborator
There was a problem hiding this comment.
Change this data here to the r4ss option
| interactive = FALSE, | ||
| make_rda = TRUE, | ||
| figures_dir = savedir) | ||
| plot_fishing_mortality(stockplotr::example_data, |
Schiano-NOAA
approved these changes
Nov 13, 2026
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
Please make the couple small adjustments then good to merge!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update extract_sis_data() and vignette with feedback from Jeff