Repository navigation
[refactor]: automate units in functions - #446
Merged
Merged
Conversation
2 tasks done
Schiano-NOAA
changed the title
Collaborator
Author
|
@sbreitbart-NOAA still looks like there are changes in this that need to be merged in. I can rebase and fix the conflicts then merge this in too |
Collaborator
Sounds good, thanks! Lmk if you'd like help- I had to resolve several issues in the other branch and may know what's causing some remainders in this branch |
Schiano-NOAA
force-pushed
the
feat-automate-units
branch
from
November 6, 2026 22:37
1279d5a to
767e791
Compare
…s argument; adjust yaxis label to fix logic
* add change to units for aa plots to extract unit from std output * update man * add warning message if unit label not found
sbreitbart-NOAA
force-pushed
the
feat-automate-units
branch
from
November 11, 2026 16:34
2514956 to
021156f
Compare
3 tasks done
This was
linked to
issues
Nov 11, 2026
… plot finishes; update plot_landings()' unit_label to filter when multiple options present
sbreitbart-NOAA
marked this pull request as ready for review
November 11, 2026 17:25
Collaborator
|
@Schiano-NOAA I rebased the branch and made some minor updates to complete the tasks. I think it's ready to merge though pls take a look to confirm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making adjustments to set the default units to NULL then having the function extract unit values from the standard output since the feature has been incorporated
Addresses #386 and the sub-issues