Repository navigation
[fix]: Fix all existing build warnings with the pkg - #474
Merged
Merged
Conversation
Oops, forgot to also add the workflow
ericward-noaa
changed the title
Contributor
Author
|
@Schiano-NOAA @sbreitbart-NOAA ready for reivew. Largely package cleanup unrelated to other commits |
ericward-noaa
marked this pull request as draft
November 7, 2026 16:56
- remove global utils - add write.csv to imports - import(rlang, .data) - typo in deprecated
sbreitbart-NOAA
changed the title
sbreitbart-NOAA
marked this pull request as ready for review
November 9, 2026 15:59
sbreitbart-NOAA
left a comment
sbreitbart-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for addressing these errors/warnings! I had made an issue to do this in the future but am glad you addressed it first! There's one minor outstanding formatting change, but otherwise this LGTM, though we'll see if @Schiano-NOAA has thoughts before merging.
Updated documentation for the 2018 Gulf of Alaska Pollock stock assessment output to clarify the use of stockplotr.
ericward-noaa
changed the title
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
This generally looks good to me as well. I am confused about the necessity of .data when pulling unit when unit is a column in the standard data frame. This would function like interacting with any other column, no?
Kind of a non-issue but I am curious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…package
What is the feature?
There's a number of warnings / notes, unrelated to my changes that have not been fixed previously
How have you implemented the solution?
Debugging / markdown fixes / etc
Does the PR impact any other area of the project, maybe another repo?
PR contribution checklist
Thank you for contributing to stockplotr! Please check the boxes below to confirm this pull request (PR) is ready for review. Edit this PR description to add the release indicator and any explanations.