Repository navigation
[fix] Fix issue with landings & index tables exporting tibbles - #483
Merged
Merged
Conversation
Contributor
Code Metrics Report
Code coverage of files in pull request scope (90.5%, patch 100.0%)
Reported by octocov |
Schiano-NOAA
approved these changes
Nov 13, 2026
Schiano-NOAA
left a comment
Schiano-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Why are the tests commented out?
Collaborator
Author
|
Thanks! I just removed the commented-out tests. The purpose of those tests- to verify rdas are made- is now covered in the save_all_plots() tests, updated by Josh a few weeks ago |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the feature?
How have you implemented the solution?
Does the PR impact any other area of the project, maybe another repo?