Skip to content

feat(recall): persist recalls as custom entries - #57

Merged
noctuid merged 1 commit into
mainfrom
custom-entry-renderer
Sep 14, 2026
Merged

noctuid merged 1 commit into
mainfrom
custom-entry-renderer

Conversation

@noctuid

@noctuid noctuid commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Store recall display data outside model context while injecting recall content ephemerally with the configured role.

Retain filtering and rendering for legacy custom_message entries, and use restricted mode when Pi lacks registerEntryRenderer.

@noctuid
noctuid requested a balanced review from Copilot September 14, 2026 21:07
@noctuid

noctuid commented Sep 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The changelog entries must remain under Pending per the repository’s contribution rules.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Persists recall display data as non-LLM custom entries while keeping model injection ephemeral and preserving legacy filtering.

Changes:

  • Adds custom-entry persistence and rendering.
  • Adds restricted mode for unsupported Pi versions.
  • Updates tests, dependencies, release metadata, and documentation.
File summaries
File Description
src/index.ts Implements recall persistence and compatibility handling.
tests/bootstrap.test.ts Tests runtime integration and legacy behavior.
tests/recall.test.ts Updates recall formatting tests.
tests/fixtures.ts Adds entry-renderer mock support.
README.md Documents Pi requirements and install version.
docs/reference.md Documents persistence and compatibility behavior.
package.json Bumps version and Pi development dependencies.
bun.lock Updates resolved dependencies.
CHANGELOG.md Adds 0.7.0 release notes.
AGENTS.md Refines contributor guidance.
AGENTFEEDBACK.md Adds agent feedback guidance.
.gitignore Ignores Org-mode task files.
Review details
  • Files reviewed: 10/12 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CHANGELOG.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 24dd6eb1cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/bootstrap.test.ts Outdated
Store recall display data outside model context while injecting recall
content ephemerally with the configured role.

Retain legacy custom_message filtering and rendering.
Use restricted mode when Pi lacks registerEntryRenderer.
@noctuid
noctuid force-pushed the custom-entry-renderer branch from 24dd6eb to 9f5e050 Compare September 14, 2026 21:29
@noctuid
noctuid merged commit 6eedad3 into main Sep 14, 2026
2 checks passed
@noctuid
noctuid deleted the custom-entry-renderer branch September 14, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants