Repository navigation
fix(recall): show auto-recall failures - #59
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Empty-string recall errors may not produce warnings, and failed-context clearing lacks integration coverage.
Pull request overview
This pull request surfaces auto-recall failures as TUI warnings while preventing failed recalls from injecting memory context.
Changes:
- Propagates auto-recall errors.
- Displays failures through warning notifications.
- Updates tests and changelog documentation.
File summaries
| File | Summary |
|---|---|
tests/recall.test.ts |
Updates recall error-result expectations. |
tests/bootstrap.test.ts |
Tests warning notifications. |
src/index.ts |
Propagates and displays auto-recall failures. |
CHANGELOG.md |
Documents the fix. |
Review details
Suppressed comments (2)
src/index.ts:663
- This truthiness check drops failures whose message is an empty string: the
RecallClientcontract permitserror: "", and the catch path also returnsError("").messageunchanged. In that case the recall is cleared but no warning is shown, contrary to the goal of surfacing every auto-recall failure; discriminate onundefinedinstead.
if (result?.error) {
tests/bootstrap.test.ts:3521
- This integration test only verifies the warning. The failure path also clears the module-level
lastRecallMessage, which the separatecontexthandler later consumes; without invoking that handler here, a regression could still inject stale or new memory context while this test passes. Please assert that the context result contains no recall message after the failedbefore_agent_start(ideally after first seeding a successful recall).
const ctx = createMockContext();
await pi.handlers.get("before_agent_start")!(
{ type: "before_agent_start", prompt: "Hello" },
ctx
);
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Surface auto-recall errors through TUI warning notifications instead of relying on console output that disappears during redraw. Continue to inject no memory context when recall fails.
noctuid
force-pushed
the
ui-auto-recall-errors
branch
from
September 14, 2026 23:45
5d10ef7 to
d482811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface auto-recall errors through TUI warning notifications instead of relying on console output that disappears during redraw. Continue to inject no memory context when recall fails.