Skip to content

tools: add option for benchmark.yml to post comment on PR#64395

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
aduh95:benchmark-comment
Jul 12, 2026
Merged

tools: add option for benchmark.yml to post comment on PR#64395
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
aduh95:benchmark-comment

Conversation

@aduh95

@aduh95 aduh95 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Adds an option for the workflow to comment on the PR to link to the workflow, and update that comment with the results. I've tested it with aduh95#43 (comment)

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 9, 2026
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 10, 2026
@aduh95 aduh95 requested a review from mcollina July 11, 2026 10:27

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 12, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2026
@nodejs-github-bot nodejs-github-bot merged commit a4821c8 into nodejs:main Jul 12, 2026
21 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a4821c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants