fs: implement glob natively by avivkeller · Pull Request #65392 · nodejs/node

avivkeller · 2026-08-18T20:25:15Z

Ref: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1787069174254509

(AI assistance used to help port minimatch to C++ and take improvements from other implementations, e.g. Rust's fast-glob [oxc] and picomatch, etc).

I'd love some pretty pedantic reviews since this is substantial. It's 1:1 with the existing glob, so it's non-breaking, but please tear this apart just in case. This implementation is over 2x faster than the old one.

Benchmarking Result

                                                                                                       confidence improvement accuracy (*)    (**)   (***)
fs/bench-glob-options.js options='exclude-callback' mode='callback' pattern='**/*.js' dir='lib' n=1000        ***    115.93 %      ±19.24% ±26.59% ±36.73%
fs/bench-glob-options.js options='exclude-callback' mode='promise' pattern='**/*.js' dir='lib' n=1000         ***    115.54 %      ±20.02% ±27.26% ±36.78%
fs/bench-glob-options.js options='exclude-callback' mode='sync' pattern='**/*.js' dir='lib' n=1000            ***     69.66 %      ±14.00% ±18.97% ±25.42%
fs/bench-glob-options.js options='exclude-pattern' mode='callback' pattern='**/*.js' dir='lib' n=1000         ***     37.86 %      ±12.27% ±16.90% ±23.19%
fs/bench-glob-options.js options='exclude-pattern' mode='promise' pattern='**/*.js' dir='lib' n=1000          ***     41.06 %      ±11.48% ±15.49% ±20.60%
fs/bench-glob-options.js options='exclude-pattern' mode='sync' pattern='**/*.js' dir='lib' n=1000                      3.81 %      ±11.93% ±16.14% ±21.56%
fs/bench-glob-options.js options='none' mode='callback' pattern='**/*.js' dir='lib' n=1000                    ***    153.86 %      ±20.91% ±28.39% ±38.12%
fs/bench-glob-options.js options='none' mode='promise' pattern='**/*.js' dir='lib' n=1000                     ***    150.49 %      ±18.20% ±24.64% ±32.95%
fs/bench-glob-options.js options='none' mode='sync' pattern='**/*.js' dir='lib' n=1000                        ***     98.16 %      ±11.23% ±15.15% ±20.14%
fs/bench-glob-options.js options='withFileTypes' mode='callback' pattern='**/*.js' dir='lib' n=1000           ***    111.98 %      ±19.57% ±26.99% ±37.14%
fs/bench-glob-options.js options='withFileTypes' mode='promise' pattern='**/*.js' dir='lib' n=1000            ***    111.56 %      ±17.41% ±23.58% ±31.53%
fs/bench-glob-options.js options='withFileTypes' mode='sync' pattern='**/*.js' dir='lib' n=1000               ***     76.30 %      ±15.82% ±21.46% ±28.80%
fs/bench-glob.js mode='callback' pattern='*.js' dir='lib' n=1000                                              ***     64.04 %       ±6.85%  ±9.31% ±12.51%
fs/bench-glob.js mode='callback' pattern='**/*.{js,json}' dir='lib' n=1000                                    ***    181.99 %       ±5.73%  ±7.78% ±10.46%
fs/bench-glob.js mode='callback' pattern='**/*.js' dir='lib' n=1000                                           ***    162.05 %       ±7.08%  ±9.77% ±13.47%
fs/bench-glob.js mode='callback' pattern='**/*' dir='lib' n=1000                                              ***    167.88 %       ±9.26% ±12.60% ±16.98%
fs/bench-glob.js mode='promise' pattern='*.js' dir='lib' n=1000                                               ***     46.39 %       ±2.77%  ±3.78%  ±5.12%
fs/bench-glob.js mode='promise' pattern='**/*.{js,json}' dir='lib' n=1000                                     ***    167.71 %       ±7.07%  ±9.74% ±13.39%
fs/bench-glob.js mode='promise' pattern='**/*.js' dir='lib' n=1000                                            ***    158.22 %      ±13.81% ±19.17% ±26.64%
fs/bench-glob.js mode='promise' pattern='**/*' dir='lib' n=1000                                               ***    156.03 %      ±11.17% ±15.48% ±21.47%
fs/bench-glob.js mode='sync' pattern='*.js' dir='lib' n=1000                                                  ***     29.58 %       ±4.99%  ±6.92%  ±9.59%
fs/bench-glob.js mode='sync' pattern='**/*.{js,json}' dir='lib' n=1000                                        ***    112.35 %       ±6.09%  ±8.24% ±11.01%
fs/bench-glob.js mode='sync' pattern='**/*.js' dir='lib' n=1000                                               ***     93.18 %       ±5.53%  ±7.60% ±10.38%
fs/bench-glob.js mode='sync' pattern='**/*' dir='lib' n=1000                                                  ***     85.16 %      ±13.12% ±18.20% ±25.31%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 24 comparisons, you can thus
expect the following amount of false-positive results:
  1.20 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.24 false positives, when considering a   1% risk acceptance (**, ***),
  0.02 false positives, when considering a 0.1% risk acceptance (***)

AI-Assisted-By: Claude Fable 5, Claude Opus 5

nodejs-github-bot · 2026-08-18T20:25:21Z

Review requested:

@nodejs/actions
@nodejs/performance
@nodejs/security-wg
@nodejs/tsc

avivkeller · 2026-08-18T20:29:08Z

cc @isaacs @nodejs/fs

codecov · 2026-08-19T03:59:08Z

Codecov Report

❌ Patch coverage is 76.78942% with 895 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.01%. Comparing base (b0d56c7) to head (ba3353a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/glob/glob_parser.cc	73.97%	149 Missing and 106 partials ⚠️
src/glob/glob_matcher.cc	66.80%	82 Missing and 84 partials ⚠️
src/glob/glob_walker.cc	84.63%	47 Missing and 104 partials ⚠️
src/glob/glob_program.cc	80.48%	78 Missing and 44 partials ⚠️
src/glob/node_glob.cc	71.78%	65 Missing and 47 partials ⚠️
src/glob/glob_unicode.cc	40.17%	64 Missing and 3 partials ⚠️
src/glob/glob_ast.h	85.29%	2 Missing and 3 partials ⚠️
src/glob/glob_unicode.h	33.33%	4 Missing ⚠️
src/glob/node_glob.h	42.85%	4 Missing ⚠️
src/glob/glob_parser.h	82.35%	2 Missing and 1 partial ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65392      +/-   ##
==========================================
- Coverage   90.19%   90.01%   -0.18%     
==========================================
  Files         770      783      +13     
  Lines      264410   267019    +2609     
  Branches    50243    50835     +592     
==========================================
+ Hits       238490   240368    +1878     
- Misses      16924    17281     +357     
- Partials     8996     9370     +374

Files with missing lines	Coverage Δ
lib/fs.js	`97.30% <100.00%> (-0.01%)`	⬇️
lib/internal/fs/watchers.js	`88.06% <100.00%> (-0.22%)`	⬇️
lib/internal/test_runner/runner.js	`94.94% <100.00%> (-0.01%)`	⬇️
src/glob/glob_program.h	`100.00% <100.00%> (ø)`
src/glob/glob_walker.h	`100.00% <100.00%> (ø)`
src/lru_cache-inl.h	`90.47% <100.00%> (+1.58%)`	⬆️
src/node_binding.cc	`70.76% <ø> (ø)`
src/node_external_reference.h	`100.00% <ø> (ø)`
src/node_snapshotable.cc	`73.53% <ø> (ø)`
src/node_util.cc	`81.39% <ø> (-0.59%)`	⬇️
... and 15 more

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 · 2026-08-19T08:22:51Z

take improvements from other implementations, e.g. Rust's fast-glob [oxc] and picomatch, etc

I would feel more comfortable adopting one of those instead of having to maintain our own, have you explored that route?

avivkeller · 2026-08-20T04:45:51Z

I would feel more comfortable adopting one of those instead of having to maintain our own, have you explored that route?

I have, but the perf wins here are dependent on this being in native, and not in JS:

(Minor) We are calling libuv directly, so we don't need to flip-flop between C++ and JS
(Major) We are writing code highly optimized for Node.js's usage. Existing JS implementations compile to a RegEx and rely on V8 to optimize it, however, we can skip that whole step by not relying on V8 at all, and manually compiling the glob to an AST.

If a directory has 100k entries and 500 match, existing implementations are forced to create and discard ~99.5k strings to get there (since they are written in JS), in a native implementation, we don't need to create, allocate, or garbage collect anything inside of V8, we can handle it all natively.

I also think this can bring some improvements to things like the test runner. For instance, --test-coverage-include/exclude is globbed on the native side (like a supercharged version of #65371), we should be able to bring this performance improvement elsewhere. Maybe this can help in similar ways in other places to?

avivkeller · 2026-08-20T04:46:31Z

(Whoops!)

isaacs · 2026-08-20T18:34:12Z

Here's the results of node-glob's benchmark script with this branch, as of fd617c2: https://gist.github.com/isaacs/abf2714edd59cb6803d36ff6b3407d22

Notes:

Correctness does not seem to be impacted in any way. That's great! Agents often take shortcuts in tasks like this, so it's good to see that the tests kept it well behaved ;)
The fs.globSync performance is a bit faster than node-glob. That's not unexpected, since it was already comparable, but it does seem to have improved.
The fs.glob performance (async) is still considerably slower. The only explanation I can imagine for this is that it's still stacking waits serially rather than parallelizing, or the more aggressive caching with path-scurry is saving node-glob from a lot of repetitive computations. (I know the node impl does cache, but it might not be caching as much or as aggressively; path-scurry effectively caches every path and fs operation for the duration of the walk.)
Performance of fast-glob and globby are there for scale, but they can be safely ignored; these implementations sacrifice correctness for speed, and thus are not apples-to-apples comparable.

Given the deep cuts made here, I'd expect to see the native implementation get at least 5 to 10 times faster than node-glob. No longer being 6x slower is indeed a significant improvement, perhaps enough to make it worth landing this as-is and making further improvements later. But it's definitely still not what I'd call "done", by quite a bit.

aduh95 · 2026-08-20T21:39:33Z

I have, but the perf wins here are dependent on this being in native, and not in JS:

It's not what I meant though, my question is whether you explored adopting one of the native alternatives your AI based itself on (you mentioned Rust, surely that is not JS)

avivkeller · 2026-08-20T22:01:59Z

It's not what I meant though, my question is whether you explored adopting one of the native alternatives your AI based itself on (you mentioned Rust, surely that is not JS)

https://github.com/oxc-project/fast-glob, the Rust implementation I mentioned, isn't compliant with minimatch (e.g. negated patterns don't work). A lot of the really fast implementations aren't compatible with our current set up (as they match different globs). As @isaacs said about a different fast-glob (a different library of the same name), "these implementations sacrifice correctness for speed, and thus are not apples-to-apples comparable." That can be said about several implementations, so working from scratch was the best way to both match the existing behavior and take the performance benefits from the existing implementations.

mcollina

lgtm

mcollina · 2026-08-21T01:22:03Z

Minimatch had its own tests that covered it extensively. Those tests have not been ported over to this codebase, which I think should be to guarantee backward-compatibility and no regressions.

stavalfi · 2026-08-27T15:42:30Z

lol right now I use fd in child process and it's still much faster than nodejs native glob. I hope this is fatwr than fd, if not, make it

jasnell · 2026-08-27T18:06:01Z

current benchmark results running on my local 88-core tower:

$ ./node benchmark/compare.js --old node --new ./node --analyze --filter glob -- fs
[00:48:33|% 100| 2/2 files | 60/60 runs | 24/24 configs]: Done
                                                                                                         confidence   improvement   accuracy (*)    (**)   (***)
fs/bench-glob-options.js options='none' mode='sync' pattern='**/*.js' dir='lib' n=1000                  ***            +40.97 %   ±0.72%  ±0.96%  ±1.26%
fs/bench-glob-options.js options='withFileTypes' mode='sync' pattern='**/*.js' dir='lib' n=1000         ***            +23.69 %   ±0.73%  ±0.97%  ±1.26%
fs/bench-glob-options.js options='exclude-pattern' mode='sync' pattern='**/*.js' dir='lib' n=1000       ***            -44.97 %   ±0.59%  ±0.79%  ±1.03%
fs/bench-glob-options.js options='exclude-callback' mode='sync' pattern='**/*.js' dir='lib' n=1000      ***             -7.44 %   ±0.56%  ±0.75%  ±0.98%
fs/bench-glob-options.js options='none' mode='promise' pattern='**/*.js' dir='lib' n=1000               ***           +158.31 %   ±1.55%  ±2.07%  ±2.71%
fs/bench-glob-options.js options='withFileTypes' mode='promise' pattern='**/*.js' dir='lib' n=1000      ***           +105.49 %   ±1.09%  ±1.45%  ±1.88%
fs/bench-glob-options.js options='exclude-pattern' mode='promise' pattern='**/*.js' dir='lib' n=1000                    -0.42 %   ±0.67%  ±0.90%  ±1.17%
fs/bench-glob-options.js options='exclude-callback' mode='promise' pattern='**/*.js' dir='lib' n=1000   ***            +77.87 %   ±1.31%  ±1.77%  ±2.34%
fs/bench-glob-options.js options='none' mode='callback' pattern='**/*.js' dir='lib' n=1000              ***           +171.57 %   ±1.60%  ±2.14%  ±2.80%
fs/bench-glob-options.js options='withFileTypes' mode='callback' pattern='**/*.js' dir='lib' n=1000     ***           +122.67 %   ±1.18%  ±1.58%  ±2.05%
fs/bench-glob-options.js options='exclude-pattern' mode='callback' pattern='**/*.js' dir='lib' n=1000   ***             +1.54 %   ±0.75%  ±1.00%  ±1.30%
fs/bench-glob-options.js options='exclude-callback' mode='callback' pattern='**/*.js' dir='lib' n=1000  ***            +89.48 %   ±1.14%  ±1.53%  ±2.00%
fs/bench-glob.js maxDepth='default' mode='sync' pattern='**/*' dir='lib' n=1000                         ***            +42.59 %   ±0.72%  ±0.96%  ±1.25%
fs/bench-glob.js maxDepth='2' mode='sync' pattern='**/*' dir='lib' n=1000                               ***           +238.79 %   ±0.85%  ±1.13%  ±1.48%
fs/bench-glob.js maxDepth='default' mode='promise' pattern='**/*' dir='lib' n=1000                      ***           +152.71 %   ±1.17%  ±1.55%  ±2.02%
fs/bench-glob.js maxDepth='2' mode='promise' pattern='**/*' dir='lib' n=1000                            ***           +491.88 %   ±3.17%  ±4.25%  ±5.61%
fs/bench-glob.js maxDepth='default' mode='callback' pattern='**/*' dir='lib' n=1000                     ***           +175.44 %   ±1.26%  ±1.69%  ±2.21%
fs/bench-glob.js maxDepth='2' mode='callback' pattern='**/*' dir='lib' n=1000                           ***           +528.15 %   ±2.79%  ±3.75%  ±4.94%
fs/bench-glob.js maxDepth='default' mode='sync' pattern='*.js' dir='lib' n=1000                         ***            +86.93 %   ±3.27%  ±4.40%  ±5.81%
fs/bench-glob.js maxDepth='2' mode='sync' pattern='*.js' dir='lib' n=1000                               ***            +80.55 %   ±3.72%  ±5.01%  ±6.64%
fs/bench-glob.js maxDepth='default' mode='promise' pattern='*.js' dir='lib' n=1000                      ***            +79.17 %   ±3.97%  ±5.33%  ±7.04%
fs/bench-glob.js maxDepth='2' mode='promise' pattern='*.js' dir='lib' n=1000                            ***            +77.51 %   ±2.85%  ±3.83%  ±5.05%
fs/bench-glob.js maxDepth='default' mode='callback' pattern='*.js' dir='lib' n=1000                     ***            +99.66 %   ±1.84%  ±2.45%  ±3.19%
fs/bench-glob.js maxDepth='2' mode='callback' pattern='*.js' dir='lib' n=1000                           ***            +94.18 %   ±1.82%  ±2.42%  ±3.15%
fs/bench-glob.js maxDepth='default' mode='sync' pattern='**/*.js' dir='lib' n=1000                      ***            +41.32 %   ±0.75%  ±1.00%  ±1.30%
fs/bench-glob.js maxDepth='2' mode='sync' pattern='**/*.js' dir='lib' n=1000                            ***           +251.10 %   ±2.17%  ±2.92%  ±3.87%
fs/bench-glob.js maxDepth='default' mode='promise' pattern='**/*.js' dir='lib' n=1000                   ***           +157.29 %   ±0.97%  ±1.29%  ±1.68%
fs/bench-glob.js maxDepth='2' mode='promise' pattern='**/*.js' dir='lib' n=1000                         ***           +528.52 %   ±3.12%  ±4.18%  ±5.53%
fs/bench-glob.js maxDepth='default' mode='callback' pattern='**/*.js' dir='lib' n=1000                  ***           +173.42 %   ±1.25%  ±1.68%  ±2.20%
fs/bench-glob.js maxDepth='2' mode='callback' pattern='**/*.js' dir='lib' n=1000                        ***           +554.18 %   ±2.45%  ±3.30%  ±4.35%
fs/bench-glob.js maxDepth='default' mode='sync' pattern='**/*.{js,json}' dir='lib' n=1000               ***            +26.95 %   ±0.61%  ±0.81%  ±1.06%
fs/bench-glob.js maxDepth='2' mode='sync' pattern='**/*.{js,json}' dir='lib' n=1000                     ***            +66.11 %   ±0.70%  ±0.93%  ±1.22%
fs/bench-glob.js maxDepth='default' mode='promise' pattern='**/*.{js,json}' dir='lib' n=1000            ***           +100.46 %   ±0.75%  ±1.00%  ±1.30%
fs/bench-glob.js maxDepth='2' mode='promise' pattern='**/*.{js,json}' dir='lib' n=1000                  ***           +194.13 %   ±0.92%  ±1.22%  ±1.59%
fs/bench-glob.js maxDepth='default' mode='callback' pattern='**/*.{js,json}' dir='lib' n=1000           ***           +118.44 %   ±0.95%  ±1.27%  ±1.66%
fs/bench-glob.js maxDepth='2' mode='callback' pattern='**/*.{js,json}' dir='lib' n=1000                 ***           +196.73 %   ±1.14%  ±1.52%  ±1.98%

                                                                                                           -556.6%            0%            +556.6%
fs/bench-glob-options.js options='none' mode='sync' pattern='**/*.js' dir='lib' n=1000                                      |                     +40.97% ***
fs/bench-glob-options.js options='withFileTypes' mode='sync' pattern='**/*.js' dir='lib' n=1000                             |                     +23.69% ***
fs/bench-glob-options.js options='exclude-pattern' mode='sync' pattern='**/*.js' dir='lib' n=1000                         ██|                     -44.97% ***
fs/bench-glob-options.js options='exclude-callback' mode='sync' pattern='**/*.js' dir='lib' n=1000                          |                     -7.44% ***
fs/bench-glob-options.js options='none' mode='promise' pattern='**/*.js' dir='lib' n=1000                                   |█████                +158.31% ***
fs/bench-glob-options.js options='withFileTypes' mode='promise' pattern='**/*.js' dir='lib' n=1000                          |███                  +105.49% ***
fs/bench-glob-options.js options='exclude-pattern' mode='promise' pattern='**/*.js' dir='lib' n=1000                        |                     -0.42%
fs/bench-glob-options.js options='exclude-callback' mode='promise' pattern='**/*.js' dir='lib' n=1000                       |██                   +77.87% ***
fs/bench-glob-options.js options='none' mode='callback' pattern='**/*.js' dir='lib' n=1000                                  |█████                +171.57% ***
fs/bench-glob-options.js options='withFileTypes' mode='callback' pattern='**/*.js' dir='lib' n=1000                         |███                  +122.67% ***
fs/bench-glob-options.js options='exclude-pattern' mode='callback' pattern='**/*.js' dir='lib' n=1000                       |                     +1.54% ***
fs/bench-glob-options.js options='exclude-callback' mode='callback' pattern='**/*.js' dir='lib' n=1000                      |██                   +89.48% ***
fs/bench-glob.js maxDepth='default' mode='sync' pattern='**/*' dir='lib' n=1000                                             |█                    +42.59% ***
fs/bench-glob.js maxDepth='2' mode='sync' pattern='**/*' dir='lib' n=1000                                                   |████████             +238.79% ***
fs/bench-glob.js maxDepth='default' mode='promise' pattern='**/*' dir='lib' n=1000                                          |████░                +152.71% ***
fs/bench-glob.js maxDepth='2' mode='promise' pattern='**/*' dir='lib' n=1000                                                |█████████████████    +491.88% ***
fs/bench-glob.js maxDepth='default' mode='callback' pattern='**/*' dir='lib' n=1000                                         |█████                +175.44% ***
fs/bench-glob.js maxDepth='2' mode='callback' pattern='**/*' dir='lib' n=1000                                               |██████████████████   +528.15% ***
fs/bench-glob.js maxDepth='default' mode='sync' pattern='*.js' dir='lib' n=1000                                             |██                   +86.93% ***
fs/bench-glob.js maxDepth='2' mode='sync' pattern='*.js' dir='lib' n=1000                                                   |██                   +80.55% ***
fs/bench-glob.js maxDepth='default' mode='promise' pattern='*.js' dir='lib' n=1000                                          |██                   +79.17% ***
fs/bench-glob.js maxDepth='2' mode='promise' pattern='*.js' dir='lib' n=1000                                                |██                   +77.51% ***
fs/bench-glob.js maxDepth='default' mode='callback' pattern='*.js' dir='lib' n=1000                                         |███                  +99.66% ***
fs/bench-glob.js maxDepth='2' mode='callback' pattern='*.js' dir='lib' n=1000                                               |██                   +94.18% ***
fs/bench-glob.js maxDepth='default' mode='sync' pattern='**/*.js' dir='lib' n=1000                                          |░                    +41.32% ***
fs/bench-glob.js maxDepth='2' mode='sync' pattern='**/*.js' dir='lib' n=1000                                                |████████             +251.10% ***
fs/bench-glob.js maxDepth='default' mode='promise' pattern='**/*.js' dir='lib' n=1000                                       |█████                +157.29% ***
fs/bench-glob.js maxDepth='2' mode='promise' pattern='**/*.js' dir='lib' n=1000                                             |██████████████████   +528.52% ***
fs/bench-glob.js maxDepth='default' mode='callback' pattern='**/*.js' dir='lib' n=1000                                      |█████                +173.42% ***
fs/bench-glob.js maxDepth='2' mode='callback' pattern='**/*.js' dir='lib' n=1000                                            |███████████████████  +554.18% ***
fs/bench-glob.js maxDepth='default' mode='sync' pattern='**/*.{js,json}' dir='lib' n=1000                                   |                     +26.95% ***
fs/bench-glob.js maxDepth='2' mode='sync' pattern='**/*.{js,json}' dir='lib' n=1000                                         |█                    +66.11% ***
fs/bench-glob.js maxDepth='default' mode='promise' pattern='**/*.{js,json}' dir='lib' n=1000                                |███                  +100.46% ***
fs/bench-glob.js maxDepth='2' mode='promise' pattern='**/*.{js,json}' dir='lib' n=1000                                      |██████               +194.13% ***
fs/bench-glob.js maxDepth='default' mode='callback' pattern='**/*.{js,json}' dir='lib' n=1000                               |███                  +118.44% ***
fs/bench-glob.js maxDepth='2' mode='callback' pattern='**/*.{js,json}' dir='lib' n=1000                                     |██████               +196.73% ***

nodejs-github-bot · 2026-08-29T04:08:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76671/

avivkeller · 2026-08-29T16:46:15Z

cc @nodejs/build, node -e const m = require('node:module'); if (m.builtinModules.includes('node:ffi')) process.exit(1); try { require('node:ffi'); } catch (e) { if (e.code === 'ERR_UNKNOWN_BUILTIN_MODULE') process.exit(0); } process.exit(1); is the reason these tests failed, but I didn't touch FFI?

nodejs-github-bot · 2026-09-01T14:46:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76833/

nodejs-github-bot · 2026-09-02T14:07:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76888/

nodejs-github-bot · 2026-09-02T20:08:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/76904/

mcollina

RSLGTM

Signed-off-by: avivkeller <me@aviv.sh>

nodejs-github-bot · 2026-09-05T19:11:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77045/

gurgunday

Nice work! I've been playing with the implementation this morning and it lgtm overall

I just have one question/concern

gurgunday · 2026-09-06T10:33:16Z

+  if (request->inline_only_) {
+    request->DoThreadPoolWork();
+    request->AfterThreadPoolWork(0);
+    return;
+  }


So inline_only_ is curious here:

inline_only_(env->permission()->enabled() || filter_ != nullptr)

If there is an exclude function for instance or permission model is enabled, we get into this path, which calls DoThreadPoolWork, and on_main_thread is true

Therefore, will the following code not block the event loop even if it's using the async implementation?

fs.glob('**/*.cc', { cwd: 'deps/v8', exclude: () => false, }, callback); console.log('returned'); // Blocked immediately because traversal is sync

For compatibility with main, the traversal itself should not be blocking in the given example

nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Aug 18, 2026

avivkeller added fs Issues and PRs related to file-system APIs and the fs module. discuss Issues opened for discussion and feedback. performance Issues and PRs related to the performance of Node.js. labels Aug 18, 2026

avivkeller force-pushed the native-glob branch from f172fce to 8bedc81 Compare August 19, 2026 02:18

avivkeller closed this Aug 20, 2026

avivkeller force-pushed the native-glob branch from 8bedc81 to 55e4ca3 Compare August 20, 2026 04:45

avivkeller reopened this Aug 20, 2026

avivkeller force-pushed the native-glob branch from fd617c2 to 77675d2 Compare August 20, 2026 20:02

jasnell reviewed Aug 20, 2026

View reviewed changes

Comment thread src/glob/glob_ast.h Outdated

jasnell reviewed Aug 20, 2026

View reviewed changes

Comment thread src/glob/glob_ast.h Outdated

avivkeller force-pushed the native-glob branch from c7f32c9 to 721c2e2 Compare August 20, 2026 23:18

avivkeller requested a review from jasnell August 20, 2026 23:40

avivkeller removed the discuss Issues opened for discussion and feedback. label Aug 20, 2026

mcollina approved these changes Aug 21, 2026

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 21, 2026

anonrig approved these changes Aug 21, 2026

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 21, 2026

avivkeller force-pushed the native-glob branch from 772c5a5 to 8bca95e Compare August 27, 2026 03:30

jasnell reviewed Aug 27, 2026

View reviewed changes

Comment thread src/glob/node_glob.cc Outdated

avivkeller force-pushed the native-glob branch from 8bca95e to fbbb04c Compare August 27, 2026 03:47

jasnell approved these changes Aug 27, 2026

View reviewed changes

panva approved these changes Aug 27, 2026

View reviewed changes

panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 27, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 27, 2026

This comment was marked as outdated.

Sign in to view

avivkeller force-pushed the native-glob branch from fbbb04c to ca1176d Compare August 31, 2026 13:51

benjamingr approved these changes Sep 1, 2026

View reviewed changes

avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 1, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 1, 2026

avivkeller force-pushed the native-glob branch from ca1176d to 6ff6ff1 Compare September 1, 2026 20:19

mcollina approved these changes Sep 4, 2026

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 4, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 4, 2026

This comment was marked as outdated.

Sign in to view

fs: implement glob natively

ba3353a

Signed-off-by: avivkeller <me@aviv.sh>

avivkeller force-pushed the native-glob branch from 6ff6ff1 to ba3353a Compare September 5, 2026 18:53

This comment was marked as outdated.

Sign in to view

gurgunday requested changes Sep 6, 2026

View reviewed changes

Uh oh!

Uh oh!

Conversation

avivkeller commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Aug 18, 2026

Uh oh!

avivkeller commented Aug 18, 2026

Uh oh!

codecov Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aduh95 commented Aug 19, 2026

Uh oh!

avivkeller commented Aug 20, 2026

Uh oh!

avivkeller commented Aug 20, 2026

Uh oh!

isaacs commented Aug 20, 2026

Uh oh!

Uh oh!

Uh oh!

aduh95 commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

avivkeller commented Aug 20, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Aug 21, 2026

Uh oh!

Uh oh!

stavalfi commented Aug 27, 2026

Uh oh!

jasnell commented Aug 27, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Aug 29, 2026

Uh oh!

avivkeller commented Aug 29, 2026

Uh oh!

nodejs-github-bot commented Sep 1, 2026

Uh oh!

nodejs-github-bot commented Sep 2, 2026

Uh oh!

nodejs-github-bot commented Sep 2, 2026

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Sep 5, 2026

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

gurgunday Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

avivkeller commented Aug 18, 2026 •

edited

Loading

codecov Bot commented Aug 19, 2026 •

edited

Loading

aduh95 commented Aug 20, 2026 •

edited

Loading