quic: add promise to QuicStream for pending strms - #65862
Open
martenrichter wants to merge 7 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Contributor
Author
jasnell
approved these changes
Sep 6, 2026
bjohansebas
added
the
request-ci
bjohansebas
approved these changes
Sep 6, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65862 +/- ##
=======================================
Coverage 90.18% 90.18%
=======================================
Files 771 771
Lines 265451 265486 +35
Branches 50452 50455 +3
=======================================
+ Hits 239398 239438 +40
+ Misses 16985 16984 -1
+ Partials 9068 9064 -4
🚀 New features to boost your workflow:
|
pimterry
reviewed
Sep 7, 2026
| added: v23.8.0 | ||
| --> | ||
|
|
||
| ### `stream.ready` |
Member
There was a problem hiding this comment.
Imo stream.opened would be a slightly clearer API, to match session.opened and stream.stats.opened_at.
Contributor
Author
There was a problem hiding this comment.
Ok, I have changed it. (Will push soon). readycame from WebStream semantics.
trivikr
added
the
quic
pimterry
reviewed
Sep 8, 2026
pimterry
left a comment
pimterry
left a comment
Member
There was a problem hiding this comment.
Thanks for the fixes @martenrichter. Code changes all look good to me.
In the docs though the name of the field is wrong, and there's now a conflict here so this'll need a rebase. Otherwise LGTM.
| --> | ||
|
|
||
| ### `stream.ready` | ||
| ### `stream.open` |
Member
There was a problem hiding this comment.
Docs say open, but the actual field is opened.
Contributor
Author
There was a problem hiding this comment.
Oh yes, fixed.
Member
|
@martenrichter ... this will need to be rebased |
before this PR, it was necessary to poll, if a stream can not be created immediately due to flow control. This PR adds a promise to QuicStream, that fulfills, when a stream is available and ready. Signed-off-by: Marten Richter <marten.richter@freenet.de>
martenrichter
force-pushed
the
addreadytoquicstream
branch
from
September 9, 2026 06:22
a31c748 to
ddfdc5d
Compare
martenrichter
commented
Sep 9, 2026
Contributor
Author
|
Is rebased, but I am not sure with one change, please look at my comment. |
pimterry
approved these changes
Sep 10, 2026
pimterry
added
the
request-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before this PR, it was necessary to poll, if a
stream can not be created immediately due to
flow control.
This PR adds a promise to QuicStream, that fulfills, when a stream is available and ready.