crypto: optimize private EC JWK import

[panva]

Avoid creating temporary EVP objects and repeating key validation while retaining the private scalar range and public/private consistency checks.

[nodejs-github-bot]

Review requested:

• @nodejs/crypto
• @nodejs/security-wg

[github-actions]

Benchmark GHA (crypto / create-keyobject): https://github.com/nodejs/node/actions/runs/34165032480

Results

[!WARNING]
Do not take GHA benchmark results as face value, always confirm them
using a dedicated machine, e.g. Jenkins CI.

Benchmark results:

                                                                              confidence improvement accuracy (*)    (**)   (***)
crypto/create-keyobject.js n=1000 keyFormat='der-pkcs8' keyType='ec'                          1.95 %       ±8.35% ±11.00% ±14.12%
crypto/create-keyobject.js n=1000 keyFormat='der-pkcs8' keyType='ed25519'                    -0.17 %       ±7.22%  ±9.51% ±12.21%
crypto/create-keyobject.js n=1000 keyFormat='der-pkcs8' keyType='ml-dsa-44'                   0.83 %       ±5.83%  ±7.68%  ±9.86%
crypto/create-keyobject.js n=1000 keyFormat='der-pkcs8' keyType='rsa'                         1.05 %       ±8.14% ±10.73% ±13.77%
crypto/create-keyobject.js n=1000 keyFormat='der-spki' keyType='ec'                           0.02 %       ±8.43% ±11.11% ±14.26%
crypto/create-keyobject.js n=1000 keyFormat='der-spki' keyType='ed25519'                      2.13 %       ±8.49% ±11.19% ±14.36%
crypto/create-keyobject.js n=1000 keyFormat='der-spki' keyType='ml-dsa-44'                   -1.08 %       ±8.76% ±11.54% ±14.81%
crypto/create-keyobject.js n=1000 keyFormat='der-spki' keyType='rsa'                         -0.80 %       ±8.59% ±11.33% ±14.53%
crypto/create-keyobject.js n=1000 keyFormat='jwk-private' keyType='ec'               ***     47.39 %       ±8.33% ±10.99% ±14.11%
crypto/create-keyobject.js n=1000 keyFormat='jwk-private' keyType='ed25519'                   2.86 %       ±7.11%  ±9.38% ±12.03%
crypto/create-keyobject.js n=1000 keyFormat='jwk-private' keyType='ml-dsa-44'                -1.51 %       ±5.43%  ±7.16%  ±9.19%
crypto/create-keyobject.js n=1000 keyFormat='jwk-private' keyType='rsa'                      -0.82 %       ±6.39%  ±8.43% ±10.81%
crypto/create-keyobject.js n=1000 keyFormat='jwk-public' keyType='ec'                        -0.34 %       ±7.51%  ±9.90% ±12.70%
crypto/create-keyobject.js n=1000 keyFormat='jwk-public' keyType='ed25519'                   -0.71 %       ±8.13% ±10.71% ±13.74%
crypto/create-keyobject.js n=1000 keyFormat='jwk-public' keyType='ml-dsa-44'                  0.34 %       ±8.09% ±10.67% ±13.69%
crypto/create-keyobject.js n=1000 keyFormat='jwk-public' keyType='rsa'                       -1.36 %       ±7.55%  ±9.95% ±12.77%
crypto/create-keyobject.js n=1000 keyFormat='pkcs8' keyType='ec'                              0.23 %       ±8.17% ±10.77% ±13.82%
crypto/create-keyobject.js n=1000 keyFormat='pkcs8' keyType='ed25519'                        -0.65 %       ±6.77%  ±8.92% ±11.45%
crypto/create-keyobject.js n=1000 keyFormat='pkcs8' keyType='ml-dsa-44'                       0.12 %       ±5.74%  ±7.57%  ±9.71%
crypto/create-keyobject.js n=1000 keyFormat='pkcs8' keyType='rsa'                             0.82 %       ±7.22%  ±9.52% ±12.21%
crypto/create-keyobject.js n=1000 keyFormat='raw-private' keyType='ec'                       -0.75 %       ±6.70%  ±8.83% ±11.33%
crypto/create-keyobject.js n=1000 keyFormat='raw-private' keyType='ed25519'                   0.23 %       ±7.01%  ±9.24% ±11.86%
crypto/create-keyobject.js n=1000 keyFormat='raw-public' keyType='ec'                        -2.00 %       ±7.24%  ±9.54% ±12.25%
crypto/create-keyobject.js n=1000 keyFormat='raw-public' keyType='ed25519'                    2.26 %       ±8.44% ±11.12% ±14.27%
crypto/create-keyobject.js n=1000 keyFormat='raw-public' keyType='ml-dsa-44'                  2.17 %       ±8.91% ±11.74% ±15.06%
crypto/create-keyobject.js n=1000 keyFormat='raw-seed' keyType='ml-dsa-44'                   -0.97 %       ±5.43%  ±7.16%  ±9.19%
crypto/create-keyobject.js n=1000 keyFormat='spki' keyType='ec'                               1.37 %       ±8.44% ±11.12% ±14.27%
crypto/create-keyobject.js n=1000 keyFormat='spki' keyType='ed25519'                          1.09 %       ±8.85% ±11.66% ±14.97%
crypto/create-keyobject.js n=1000 keyFormat='spki' keyType='ml-dsa-44'                       -0.09 %       ±7.75% ±10.22% ±13.12%
crypto/create-keyobject.js n=1000 keyFormat='spki' keyType='rsa'                              0.61 %       ±8.46% ±11.16% ±14.31%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 30 comparisons, you can thus
expect the following amount of false-positive results:
  1.50 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.30 false positives, when considering a   1% risk acceptance (**, ***),
  0.03 false positives, when considering a 0.1% risk acceptance (***)

[!WARNING]
Do not take GHA benchmark results as face value, always confirm them
using a dedicated machine, e.g. Jenkins CI.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (8d1d7b6) to head (4b09a2f).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #65893      +/-   ##
==========================================
- Coverage   90.18%   90.18%   -0.01%     
==========================================
  Files         771      771              
  Lines      265097   265097              
  Branches    50358    50362       +4     
==========================================
- Hits       239083   239067      -16     
- Misses      16961    16977      +16     
  Partials     9053     9053              

Files with missing lines	Coverage Δ
src/crypto/crypto_ec.cc	69.23% <100.00%> (+0.80%)	⬆️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.