Skip to content

sqlite: track registered user-defined functions - #65896

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:sqlite-track-registered-user-fns
Open

sqlite: track registered user-defined functions#65896
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:sqlite-track-registered-user-fns

Conversation

@trivikr

@trivikr trivikr commented Sep 7, 2026

Copy link
Copy Markdown
Member

Fixes: #65880

Track scalar and aggregate/window functions on each DatabaseSync instance. Remove registrations through SQLite destruction callbacks and clear tracking when the database closes.


Assisted-by: codex

Track scalar and aggregate/window functions on each DatabaseSync
instance. Remove registrations through SQLite destruction callbacks
and clear tracking when the database closes.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: codex
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 7, 2026
@trivikr
trivikr requested a review from geeksilva97 September 7, 2026 23:58
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (b4c83f5) to head (2df372f).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 73.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65896   +/-   ##
=======================================
  Coverage   90.16%   90.17%           
=======================================
  Files         771      771           
  Lines      265094   265109   +15     
  Branches    50367    50360    -7     
=======================================
+ Hits       239035   239050   +15     
- Misses      17000    17005    +5     
+ Partials     9059     9054    -5     
Files with missing lines Coverage Δ
src/node_sqlite.h 86.40% <ø> (ø)
src/node_sqlite.cc 82.08% <73.33%> (-0.07%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite: track registered user-defined functions

4 participants