Skip to content

sqlite: use cached strings for property keys - #65902

Open
kyungrae2002 wants to merge 1 commit into
nodejs:mainfrom
kyungrae2002:sqlite-use-cached-property-strings
Open

sqlite: use cached strings for property keys#65902
kyungrae2002 wants to merge 1 commit into
nodejs:mainfrom
kyungrae2002:sqlite-use-cached-property-strings

Conversation

@kyungrae2002

Copy link
Copy Markdown
Contributor

Use strings cached in Environment when accessing commonly used node:sqlite property keys.
Replace FIXED_ONE_BYTE_STRING() calls in the SQLite bindings with the corresponding strings cached by Environment.

This avoids creating the same V8 strings at each call site and makes the SQLite binding consistent with other Node.js core modules that use Environment string getters.

No intended behavioral changes.

Signed-off-by: Kyungrae Kang <kyungrae2002@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 8, 2026
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (6f38736) to head (551eeb6).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 33.33% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65902      +/-   ##
==========================================
- Coverage   92.40%   90.17%   -2.24%     
==========================================
  Files         417      771     +354     
  Lines      188648   265088   +76440     
  Branches    28849    50363   +21514     
==========================================
+ Hits       174320   239041   +64721     
- Misses      13995    17008    +3013     
- Partials      333     9039    +8706     
Files with missing lines Coverage Δ
src/node_sqlite.cc 82.08% <33.33%> (ø)

... and 487 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants