lib: avoid repeat internal receiver checks - #65910
Open
panva wants to merge 1 commit into
Open
Conversation
Let internal helpers access the private cache directly to avoid repeating receiver checks. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
Contributor
|
Benchmark GHA (crypto / class-methods): https://github.com/nodejs/node/actions/runs/34225714923 Results
Benchmark results:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65910 +/- ##
==========================================
- Coverage 90.18% 90.17% -0.01%
==========================================
Files 771 771
Lines 265103 265072 -31
Branches 50353 50348 -5
==========================================
- Hits 239082 239039 -43
- Misses 16968 16998 +30
+ Partials 9053 9035 -18
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let internal helpers access the private cache directly to avoid repeating receiver checks since CryptoKey webidl now does the brand check.
Update test coverage to ensure future public getters or methods don't forget the brand check.
Refs: #65846