Skip to content

benchmark: add --csv option to compare.js with --analyze - #65922

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/bench-compare-csv
Open

benchmark: add --csv option to compare.js with --analyze#65922
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/bench-compare-csv

Conversation

@jasnell

@jasnell jasnell commented Sep 9, 2026

Copy link
Copy Markdown
Member

Add a --csv {filename} option to benchmark/compare.js to capture the CSV when the --analyze option is used

@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 9, 2026
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from 520b0e2 to df6708b Compare September 9, 2026 01:27
@codecov

codecov Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (ffc4203) to head (77be9bd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #65922   +/-   ##
=======================================
  Coverage   90.17%   90.18%           
=======================================
  Files         771      771           
  Lines      265470   265470           
  Branches    50467    50456   -11     
=======================================
+ Hits       239382   239406   +24     
+ Misses      17033    17023   -10     
+ Partials     9055     9041   -14

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95
aduh95 reviewed Sep 10, 2026
View reviewed changes
Comment thread doc/contributing/writing-and-running-benchmarks.md Outdated
aduh95
aduh95 reviewed Sep 10, 2026
View reviewed changes
Comment thread benchmark/compare.js Outdated
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from df6708b to 2c335f8 Compare September 10, 2026 15:45
@jasnell

jasnell commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

ok, had to tweak it a bit more to account for the progress display... but passing --csv - --analyze will now print the raw data followed by the analysis to process.stdout

@jasnell
jasnell requested a review from aduh95 September 10, 2026 15:47
aduh95
aduh95 reviewed Sep 10, 2026
View reviewed changes
Comment thread benchmark/compare.js Outdated
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from 2c335f8 to 53b9e22 Compare September 10, 2026 16:00
@jasnell
jasnell requested a review from aduh95 September 10, 2026 16:00
aduh95
aduh95 reviewed Sep 10, 2026
View reviewed changes
Comment thread benchmark/compare.js Outdated
@jasnell
jasnell requested a review from aduh95 September 10, 2026 16:38
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from c6e0e3a to 0ad655a Compare September 10, 2026 20:53
@aduh95

aduh95 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Can you address the linter failures?

@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from 0ad655a to 363ebf9 Compare September 10, 2026 21:52
aduh95
aduh95 reviewed Sep 10, 2026
View reviewed changes
Comment thread test/parallel/test-benchmark-compare.js Outdated
@jasnell
benchmark: add --csv option to compare.js with --analyze
77be9bd 
Add a `--csv {filename}` option to benchmark/compare.js
to capture the CSV when the `--analyze` option is used

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell force-pushed the jasnell/bench-compare-csv branch from 68c4812 to 77be9bd Compare September 10, 2026 22:28
@jasnell
jasnell requested a review from aduh95 September 10, 2026 22:28
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 10, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77326/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes
@mcollina mcollina Awaiting requested review from mcollina
@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasnell @nodejs-github-bot @aduh95