url: add Symbol.toStringTag to URLPattern - #65925
Open
XadillaX wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
meixg
approved these changes
Sep 9, 2026
meixg
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65925 +/- ##
==========================================
- Coverage 92.40% 90.17% -2.24%
==========================================
Files 417 771 +354
Lines 188989 265489 +76500
Branches 28924 50467 +21543
==========================================
+ Hits 174642 239393 +64751
- Misses 14015 17045 +3030
- Partials 332 9051 +8719
🚀 New features to boost your workflow:
|
jazelly
approved these changes
Sep 9, 2026
panva
added
the
author ready
avivkeller
approved these changes
Sep 9, 2026
avivkeller
added
the
request-ci
aduh95
added
request-ci
jasnell
reviewed
Sep 10, 2026
| ctor_tmpl->SetClassName(FIXED_ONE_BYTE_STRING(isolate, "URLPattern")); | ||
| prototype_template->Set( | ||
| v8::Symbol::GetToStringTag(isolate), | ||
| FIXED_ONE_BYTE_STRING(isolate, "URLPattern"), |
Member
There was a problem hiding this comment.
Just create the URLPattern string once and use it both in SetClassName and the call to Set.
Contributor
Author
There was a problem hiding this comment.
Done. The URLPattern string is now created once and reused for both SetClassName() and Symbol.toStringTag.
Define Symbol.toStringTag on URLPattern.prototype so its class string matches the Web IDL interface name. Add coverage for the property descriptor and Object.prototype.toString(). Fixes: nodejs#65924 Signed-off-by: XadillaX <i@2333.moe>
XadillaX
force-pushed
the
fix-urlpattern-tostringtag
branch
from
September 10, 2026 04:44
01ab95b to
90a0e33
Compare
jakecastelli
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
Symbol.toStringTagonURLPattern.prototypeso that the class string matches the Web IDL interface name. Add regression coverage for the property descriptor andObject.prototype.toString()result.Fixes: #65924