test: fix flaky common WPT inspector test - #65937
Open
inoway46 wants to merge 1 commit into
Open
Conversation
Wait for the WPT child to reach its startup wait before sending Runtime.runIfWaitingForDebugger. Signed-off-by: inoway46 <inoueyuya416@gmail.com> Assisted-by: Codex
inoway46
marked this pull request as ready for review
September 9, 2026 11:52
panva
approved these changes
Sep 9, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65937 +/- ##
==========================================
+ Coverage 90.16% 90.17% +0.01%
==========================================
Files 771 771
Lines 265434 265434
Branches 50450 50460 +10
==========================================
+ Hits 239332 239365 +33
+ Misses 17045 17011 -34
- Partials 9057 9058 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/parallel/test-common-wpt-inspect.jsoccasionally times out while waiting forDebugger.pausedin the macOS CI job.The inspector connection can be established before the WPT child reaches its startup wait. In that case,
Runtime.runIfWaitingForDebuggercan be sent too early, leaving the child blocked in the startup wait.Wait for
NodeRuntime.waitingForDebuggerbefore resuming the target, consistent with other inspector tests (https://github.com/nodejs/node/blob/main/test/parallel/test-esm-loader-hooks-inspect-brk.js#L17-L25).Failed CI runs