Skip to content

Small improvements to several actor classes - #61

Merged
Luminyx1 merged 4 commits into
nsmbu:mainfrom
Ryguy0777:brosbasecrap
Oct 24, 2026
Merged

Luminyx1 merged 4 commits into
nsmbu:mainfrom
Ryguy0777:brosbasecrap

Conversation

@Ryguy0777

Copy link
Copy Markdown
Contributor
  • Adds a getter for mPosDelta in Actor
  • Adds a definition for the checkBombBreak function in ActorBgCollisionCheck
  • Correctly types the return type of vf58C in BrosBase
  • Adds a definition for initModel in BrosBase
  • Adds a definition and getter for mCarryPlayerNo in ChibiYoshiBase

Comment thread collision/ActorBgCollisionCheck.h Resolved
Comment thread actor/Actor.h Resolved
Comment thread enemy/BrosBase.h Outdated
public:
// Address: Deleted
virtual void vf58C();
virtual sead::Vector3f getCreateWeaponPos();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is getCreateWeaponPos more accurate or getHandPos? not too familiar with the purpose of this vf

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really too sure either. The purpose of the function is to get the world position for the projectile after it has been spawned but before it has been thrown as seen in the attachment (in this case, it gets the position the hammer should be placed).
{C7AA8403-3073-4FD5-8F54-ED1BA19A4578}
I don't think getCreateWeaponPos is a good name anymore since this function is also called by the projectile during it's execution to move with the bro. I also don't think getHandPos is very Nintendo like.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it follows the bone, right? what is the bone named?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The virtual is deleted in the base class, it's up to child classes to add this behavior. It uses the wrist_r1 bone with an offset added to it depending on the facing direction.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NSMBW just uses the translation vector of wrist_r1 directly so there's no official names to compare to.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just getWristPos in that case, I guess.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Ryguy0777
Ryguy0777 requested a review from Luminyx1 October 24, 2026 04:58
@Luminyx1
Luminyx1 merged commit 9e4ca1f into nsmbu:main Oct 24, 2026
1 check passed
@Ryguy0777
Ryguy0777 deleted the brosbasecrap branch October 24, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants