Wrap use of PyWeakref_GET_OBJECT if we need it - #273
Merged
MatthieuDartiailh merged 2 commits intoSep 9, 2026
Merged
MatthieuDartiailh merged 2 commits into
MatthieuDartiailh merged 2 commits into
Conversation
Python 3.15 removes PyWeakref_GET_OBJECT, and the path forward is by using PyWeakref_GetRef, which was only added in Python 3.13. Add a wrapper for it if required, and switch to using PyWeakref_GetRef everywhere that called PyWeakref_GET_OBJECT.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 24 24
Lines 1093 1093
Branches 167 167
=======================================
Hits 1066 1066
Misses 13 13
Partials 14 14 🚀 New features to boost your workflow:
|
Member
|
Thanks for your contribution. Could you also add 3.15 to the test and release matrix ? |
Contributor
Author
I have not added it to the release matrix for now, since 3.15 final isn't out quite yet. |
Member
|
The typing error is unrelated so I will merge thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.15 removes PyWeakref_GET_OBJECT, and the path forward is by using PyWeakref_GetRef, which was only added in Python 3.13. Add a wrapper for it if required, and switch to using PyWeakref_GetRef everywhere that called PyWeakref_GET_OBJECT.