Skip to content

Wrap use of PyWeakref_GET_OBJECT if we need it - #273

Merged
MatthieuDartiailh merged 2 commits into
nucleic:mainfrom
s-t-e-v-e-n-k:support-no-pyweakref-get-object
Sep 9, 2026
Merged

MatthieuDartiailh merged 2 commits into
nucleic:mainfrom
s-t-e-v-e-n-k:support-no-pyweakref-get-object

Conversation

@s-t-e-v-e-n-k

Copy link
Copy Markdown
Contributor

Python 3.15 removes PyWeakref_GET_OBJECT, and the path forward is by using PyWeakref_GetRef, which was only added in Python 3.13. Add a wrapper for it if required, and switch to using PyWeakref_GetRef everywhere that called PyWeakref_GET_OBJECT.

Python 3.15 removes PyWeakref_GET_OBJECT, and the path forward is by
using PyWeakref_GetRef, which was only added in Python 3.13. Add a
wrapper for it if required, and switch to using PyWeakref_GetRef
everywhere that called PyWeakref_GET_OBJECT.
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.52%. Comparing base (2f8fd13) to head (6f1baad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files          24       24           
  Lines        1093     1093           
  Branches      167      167           
=======================================
  Hits         1066     1066           
  Misses         13       13           
  Partials       14       14           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthieuDartiailh

Copy link
Copy Markdown
Member

Thanks for your contribution. Could you also add 3.15 to the test and release matrix ?

@s-t-e-v-e-n-k

Copy link
Copy Markdown
Contributor Author

Thanks for your contribution. Could you also add 3.15 to the test and release matrix ?

I have not added it to the release matrix for now, since 3.15 final isn't out quite yet.

@MatthieuDartiailh

Copy link
Copy Markdown
Member

The typing error is unrelated so I will merge thanks

@MatthieuDartiailh
MatthieuDartiailh merged commit d1a980b into nucleic:main Sep 9, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants