Repository navigation
Conversation
…ions A hand-written Transitions/CheckTransition rule is Unclassified, so no axis ran it and a planted bug left the suite green. The invariant axis now checks those rules on every step its operations take, and is a case when only unclassified rules and operations exist. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Why: a hand-written
Transitions/CheckTransitionrule isUnclassified, so no axis ran it.InvariantAsynconly looked atAxis.Invariantrules, so a planted bug the rule should catch left the suite green; only the report line mentioned it.What: this takes the first option from the issue.
OperationsKeepInvariantsnow also checks unclassified rules on every step the operations take. The Invariant axis is applicable (and a case inCases) when a set has only unclassified rules and there are operations. The report line now says they are checked against the operations.Not done: Vacancy counter-examples for unclassified rules, or an
AllowUnclassified()opt-in.Tests: new
A_hand_written_transition_rule_is_attacked_by_the_operations_and_fails_when_one_breaks_itfails without the change and passes with it. The full CsCheck suite passes on net10.0 (313/313). I did not run net11.0.🤖 Generated with Claude Code