Repository navigation
Conversation
A Gen.Const base is one MockFileSystem, and axes run at the same time. FileWorld's name counter was not atomic and its file-system edits were unlocked, so two threads could create the same symlink; a given counter-example was applied once per axis. The counter is now atomic, draws lock the file system, and a counter-example given to AutoTest runs once per base under a lock on it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #46
Invariant and Vacancy run at the same time over one
Gen.Constbase, so they share oneMockFileSystem. Two things raced on it:FileWorld's name counter wasValue++and its edits were unlocked, so two threads could make the same symlink (The file 'path' already exists).AutoTestran once per axis against the same base.Fix: the counter is atomic and
FileWorlddraws lock the file system; a given counter-example now runs once per base (under a lock on it) and later axes reuse the result. The file system is not cloned, so a counter-example that edits the base's own file still changes it; the README says to add files instead.Test:
A_counter_example_that_adds_a_file_survives_axes_running_at_once_on_one_constant_basefailed with the IOException before the fix (also after only theAutoTesthalf) and passes 6 of 6 runs after, on net10.0 and net11.0.Nullean.Entities.CsCheck.Tests(312) pass.🤖 Generated with Claude Code