Skip to content

Faults() with several starts: throw only for faults no start catches - #104

Open
Mpdreamz wants to merge 1 commit into
mainfrom
heed/browse/issue-35-b00d50
Open

Mpdreamz wants to merge 1 commit into
mainfrom
heed/browse/issue-35-b00d50

Conversation

@Mpdreamz

Copy link
Copy Markdown
Contributor

Closes #35

Why: Faults() and SampleFaults() asked CsCheck to throw on uncaught faults per start. A fault that only one start can trigger (e.g. the Locked start takes Close, the Closed start never reaches it) is uncaught from the other starts by construction, so the call threw even though a start caught it.

What: every start now runs with throwOnUncaught: false. After all starts, a fault counts as a gap only if it was uncaught from every start; then it throws the same CsCheckException message as before. Single-start behaviour is unchanged.

Test: Faults_with_several_starts_counts_a_fault_caught_from_any_start failed before the fix (No requirement detects these faults: Close from Locked opens). Full CsCheck test project passes on net10.0 (313/313). net11.0 not run.

🤖 Generated with Claude Code

A fault only some starts can trigger was reported uncaught from the others,
so Faults()/SampleFaults() threw on the first such start. Run every start
without throwing and fail only for faults uncaught from all of them.

Closes #35

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faults() with several starts reports a fault as uncaught when only another start can trigger it

1 participant