Repository navigation
Skip <Clone>$ when inferring actions for a record from another assembly - #99
Merged
Merged
Conversation
…from metadata types IsImplicitlyDeclared is false for symbols read from another assembly, so the record's <Clone>$ became an EntityAction that does not compile. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91
The action filter relied on
IsImplicitlyDeclared, which is false for symbols read from metadata, so<Clone>$became anEntityAction(CS1001/CS1056). It now also requiresCanBeReferencedByName.Test:
A_record_from_another_assembly_gets_no_action_for_its_compiler_generated_memberscompiles a Lib assembly and references it as metadata; it failed before the fix and passes now. SourceGenerators tests pass on net10.0 (net11.0 not run).🤖 Generated with Claude Code