Repository navigation
fix(ssh): reject ECDSA private keys with a too-small scalar - #49
Merged
Merged
Conversation
timweri
force-pushed
the
fix/ecdsa-short-scalar
branch
from
September 25, 2026 03:03
cd8634d to
f2f5826
Compare
timweri
changed the title
timweri
marked this pull request as ready for review
September 25, 2026 03:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECDSA signing now rejects private keys whose scalar is at most half the curve order's size (16 bytes on P-256, 24 on P-384), matching OpenSSH's check. A new P-256 test key with scalar 2^128-1 confirms signing fails, while the existing short-scalar keys from #47 still sign.