Skip to content

Unjustified xml-reason test packs require conversion or legitimate justification #1475

Description

@volodya-lombrozo

#1463 added a check (LtByXslTest.checksDocumentUsageIsJustified) that fails when a pack uses document: (raw XMIR) without an xml-reason: key explaining why. To land that check without blocking on a full audit, I put a standard placeholder, xml-reason: "not yet converted to an EO input test", on the 156 packs I hadn't reviewed yet (only the 4 genuinely XML-only object-has-data packs got a real reason).

I need to go through those 156 packs one by one and, for each, either:

  • rewrite it using input: (EO source) when the pack doesn't rely on an invariant a valid EO parse can never produce, or
  • replace the placeholder with a real xml-reason: when raw XMIR is actually required.

The placeholder text is what makes the remaining work greppable: grep -rl 'not yet converted to an EO input test' src/test/resources/org/eolang/lints/packs.

Relevant classes to investigate: LtByXslTest, YamlPack.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or requestgood-titleThe title was checked and improved by ChatGPT

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions