Skip to content

benchmark-diff.sh incorrectly parses CSV fields with commas inside quotes #1492

Description

@gemshrine

Problem

.github/benchmark-diff.sh claims to process CSV files but removes every double quote from each field and splits only on commas. A quoted field containing a comma is therefore parsed as multiple columns.

Steps to reproduce

Create a baseline or current benchmark row whose first field is quoted and contains a comma, for example:

"lint,with-comma",10

Run benchmark-diff.sh baseline.csv current.csv 1.

Actual result

The first field is split at the comma, so the benchmark is assigned the wrong identifier and the comparison table is corrupted.

Expected result

Parse quoted CSV fields according to CSV rules, preserving commas inside quoted benchmark names.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood-titleThe title was checked and improved by ChatGPT

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions