Skip to content

benchmark-diff.sh truncates fractional part of benchmark deltas #1493

Description

@gemshrine

Problem

.github/benchmark-diff.sh formats numeric deltas with %d in the AWK report. Benchmark timings can contain fractional values, so this truncates the measured change before it is shown in the comparison table.

Steps to reproduce

Compare a baseline value of 10.4 with a current value of 11.1.

Actual result

The delta is printed as an integer (0), hiding the 0.7 ms regression.

Expected result

Keep the fractional precision of benchmark measurements when printing the delta and when deciding which changes to report.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood-titleThe title was checked and improved by ChatGPT

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions