Conversation
Add xslint workflow and drop the XSLT 3.0 map constructor from defect-context.xsl, since serialize() already defaults to the xml method
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds CI linting for XSL stylesheets using xslint and fixes an xslint-reported XPath/XSLT compatibility issue in defect-context.xsl.
Changes:
- Introduces a new GitHub Actions workflow to run
xslinton pushes/PRs tomaster. - Removes XPath 3.1 map constructor usage from
defect-context.xslby relying on defaultserialize()behavior.
| File | Description |
|---|---|
src/main/resources/org/eolang/funcs/defect-context.xsl |
Adjusts serialization call to avoid XPath 3.1 map constructor under an XSLT 2.0 declaration. |
.github/workflows/xslint.yml |
Adds a CI workflow to run xslint in GitHub Actions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+23
to
+26
| - uses: actions/checkout@v7 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: xslint/xslint-action@0.0.14 |
| @@ -6,6 +6,6 @@ | |||
| <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" xmlns:eo="https://www.eolang.org" xmlns:xs="http://www.w3.org/2001/XMLSchema" id="defect-context" version="2.0"> | |||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| timeout-minutes: 15 | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: actions/checkout@v7 |
| - uses: actions/checkout@v7 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: xslint/xslint-action@0.0.14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1524.
This adds an
xslintworkflow, the same one objectionary/eo runs, so every push and pull request checks all 99 stylesheets in the repository.xslint found one defect.
defect-context.xsldeclares XSLT 2.0 but used the XPath 3.1 map constructor.serialize()already uses thexmlmethod by default, so the map was redundant:With that fix, xslint 0.6.0 reports no defects locally.