Conversation
A private constant written with "!" carries its local name two levels below the attribute, so the "not(@Local)" guard missed it and the lint asked to obfuscate an attribute that was already obfuscated. The rule now skips every attribute whose name holds the cactus, the same guard unoptimizable-recursion uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
excessive-visibilitylint decided an attribute was private by checkingnot(@local). That works forx >> y, but not forx >> y!. For the!form, the parser wraps the value in.as-bytesofΦ.dataizedand putslocal="y"on the inner argument, two levels below the attribute the rule looks at. So the lint told people to obfuscate attributes that were already obfuscated. Ineo-runtimethis accounts for 71 of the 152 warnings.The rule now skips every attribute whose generated name holds the cactus, which is the same guard
unoptimizable-recursion.xslalready uses:The new pack
allows-already-private-constant.yamlreproduces the case from the issue withx.plus 1 >> y!. It failed before the change and passes now. The existingallows-already-private-method.yamlpack still passes, so the plain>>form stays covered.Closes #1526