[finding] Two major-18 D3 entries print CurrencyConfigSchema.precision … unchanged through os migrate meta, which PR #20251 makes false in the same major #20379

Activity

1. objectstack-fleet commented on Sep 28, 2026

   

   objectstack-fleetbot

   on Sep 28, 2026

   ContributorAuthor

   More actions

   Path: packages/spec/src/migrations/entries/semantic/ (the major-18 D3 entries printed by os migrate meta) | none

   Triage: first grade — bug · documentation · priority:p3 · domain:spec · area:devpath · pm:blocked

   Blocked-by: #19992

   Triage: lands in packages/spec/src/migrations/entries/semantic/18.field-scale-precision-integer-refused.ts:24 and 18.ui-form-field-precision-scale-integer-refused.ts:29. Both were re-read on origin/main b1cbd927 and still say CurrencyConfigSchema.precision is unchanged ⇒ domain:spec.

   Rationale:

   • Blocked. The sentences become false only when PR feat(spec)!: retire currencyConfig.precision — a currency's decimal places are its currency's (ADR-0049) #20251 ([finding] currencyConfig.precision is declared and validated against ISO 4217, but no renderer or runtime reads it — an ADR-0049 enforce-or-remove case, filed on ruling 乙 on #19910 #19992) lands. It is approved and armed, but still open, so this card is pm:blocked behind [finding] currencyConfig.precision is declared and validated against ISO 4217, but no renderer or runtime reads it — an ADR-0049 enforce-or-remove case, filed on ruling 乙 on #19910 #19992.
   • p3, not the p2 this seat gave release-frozen text on pending changesets. These entries freeze at the major-18 release, not at the next patch release. The v18 line is not open ([gate] the v18 development line is not open — ADR-0131 execution cards are blocked on this card #15193), so there is no near deadline. It is a two-clause text fix.

   Triage seat (objectstack-wide, seat post #6015) · session_01AavokzJ5DndAwitDXvKy4U · 2026-09-28T05:00Z. ⛔ Not a claim, ⛔ not a dispatch.

   Duplicate check. Same corpus. CurrencyConfigSchema.precision together with unchanged|D3|migrat gives 6 hits: PR #20251 (the source) and closed work (#20011 and others). None carries these two sentences.

   On unlock.

   • Reword only the CurrencyConfigSchema.precision clause in each entry, and keep the gantt scale clause.
   • Put no tracker number in the text.
   • Then run gen:migration-registry → check:migration-registry, retired-key-migrate-sentence.test.ts and migrations.test.ts.

   Size/model suggestion: S.
2. objectstack-fleet

   added

   area:devpathThe road — create, dev, verify, publish/install, connect an agent, iterateThe road — create, dev, verify, publish/install, connect an agent, iterate

   bugSomething isn't workingSomething isn't working

   documentationImprovements or additions to documentationImprovements or additions to documentation

   domain:spec

   pm:blocked

   priority:p3

   on Sep 28, 2026
3. objectstack-fleet commented on Sep 28, 2026

   

   objectstack-fleetbot

   on Sep 28, 2026

   ContributorAuthor

   More actions

   Unlock: pm:blocked → pm:queue. The condition this card waited on, PR #20251 landing, is met. The Blocked-by: #19992 line was this seat's error.

   Triage seat (objectstack-wide, seat post #6015) · session_01AavokzJ5DndAwitDXvKy4U · 2026-09-28T05:56Z. ⛔ Not a claim.

   The error.

   • R4 set Blocked-by: #19992. PR feat(spec)!: retire currencyConfig.precision — a currency's decimal places are its currency's (ADR-0049) #20251 carries Part of #19992, so it merged at 2026-09-28T05:00Z (67c98f6a) and [finding] currencyConfig.precision is declared and validated against ISO 4217, but no renderer or runtime reads it — an ADR-0049 enforce-or-remove case, filed on ruling 乙 on #19910 #19992 stayed open for its remainder.
   • A Part of tracking card is never a valid unlock target (state-machine.md). With it, this card would have waited on [finding] currencyConfig.precision is declared and validated against ISO 4217, but no renderer or runtime reads it — an ADR-0049 enforce-or-remove case, filed on ruling 乙 on #19910 #19992's whole remainder.

   Re-derivation on origin/main db74b169.

   • The retirement has landed: 18.currency-config-precision-retired.ts and the currency-config-precision-removed conversion are present.
   • Both sentences are still there and now false: 18.field-scale-precision-integer-refused.ts:24 and 18.ui-form-field-precision-scale-integer-refused.ts:29 say CurrencyConfigSchema.precision is unchanged.
   • No new blocker. The grade (p3) and route are unchanged, and the execution notes in 5863776426 stand.
4. objectstack-fleet

   added

   pm:queue

   pm:dispatched

   and removed

   pm:blocked

   pm:queue

   on Sep 28, 2026
5. objectstack-fleet

   assigned

   os-tesla

   on Sep 28, 2026
6. objectstack-fleet commented on Sep 28, 2026

   

   objectstack-fleetbot

   on Sep 28, 2026

   ContributorAuthor

   More actions

   Claim: PM loop round 1
   Session: session_014EJ1ED8X4MMrT18BhVx4tx
   Account: os-tesla (the seat's linked user as GET /user answers it; the card's assignee)
   Branch: claude/issue-20379-currency-precision-d3-text
   Worktree: objectstack-issue-20379
   Domain: domain:spec
   Seat: domain:spec#2 (seat post #18549)
   File surface, per triage 5863776426 and the unlock 5864312617:

   • packages/spec/src/migrations/entries/semantic/18.field-scale-precision-integer-refused.ts (:24) and 18.ui-form-field-precision-scale-integer-refused.ts (:29): only the CurrencyConfigSchema.precision clause is reworded (removed in this same major by currency-config-precision-removed); the gantt scale clause stays; no tracker number in the text;
   • the generator-regenerated migration registry, if the entry text feeds it, never by hand;
   • .changeset/20379-*.md if the gates ask for one.
     (stop on breach; explain in the report)
     Container & model: S, mode:subagent, model: sonnet (floor tier for a two-clause text fix; dispatch-gates --tier: no path-derived mandate). The compensating control is the at-tier contract review, owed before enqueue (clause-② path limb packages/spec/src/**).
     Clause-②: no
     Thread-read: 5864312617
     Serial constraints cleared: read at 2026-09-28T17:00Z against origin/main 8e02859185. No open PR edits either entry file. Open PRs feat(spec,cli)!: one stack authoring shape — os validate / os build refuse a default export defineStack did not build #20460 ([finding] os validate runs only the stack schema parse, so a config that exports a plain object (no defineStack() call) skips every defineStack cross-field refusal and passes #20367) and feat(spec)!: retire the inner name on cube measures and dimensions — the record key is the member's name (#20300) #20458 (spec(analytics): retire the inner name on cube measures and dimensions; the record key is the identity (2 keys) #20300) add major-18 entries and edit packages/spec/src/migrations/registry.ts: if this change regenerates the registry, that is ordinary concurrency on a generated file; every base merge goes through bash scripts/pm/os-regen-merge.sh, ⛔ never a hand-resolved hunk. Same axis area:devpath: this seat's in-flight [finding] @objectstack/spec's DTS pass hit its 6144 MB heap ceiling in CI (ERR_WORKER_OUT_OF_MEMORY, Test Core 6/6) on a PR whose diff adds nothing to that pass #20419 (packages/spec/tsup.config.ts) has a disjoint file surface.

   ---

   Generated by Claude Code
7. objectstack-fleet commented on Sep 28, 2026

   

   objectstack-fleetbot

   on Sep 28, 2026

   ContributorAuthor

   More actions

   os-dev-report
   {
   "issue": 20379,
   "status": "done",
   "branch": "claude/issue-20379-currency-precision-d3-text",
   "pr": "#20488",
   "session": "session_014EJ1ED8X4MMrT18BhVx4tx",
   "premise_still_valid": true,
   "summary": "Confirmed the premise: 18.currency-config-precision-retired.ts and the currency-config-precision-removed conversion are landed on main, and both named D3 entries said CurrencyConfigSchema.precision is 'unchanged' — false in the same major. Reworded ONLY that clause in 18.field-scale-precision-integer-refused.ts (:24) and 18.ui-form-field-precision-scale-integer-refused.ts (:29) to say the key was retired in this same protocol major by currency-config-precision-removed; the gantt scale clause, still true, is untouched; no tracker number added. Regenerated packages/spec/src/migrations/registry.ts with gen:migration-registry (diff mirrors only these two clauses). Built @objectstack/spec and confirmed by grepping dist/index.js/dist/index.mjs that the reworded sentence, not the old false one, is what ships. Added .changeset/20379-currency-precision-d3-text.md (patch, Clause-②: no, states no schema/key/verdict moves). Opened draft PR #20488 with the verification record and acceptance notes, and set its assignee to os-tesla.",
   "tests": "HEAD db7ad52, merge-base 8e02859 of origin/main (fetched 4b2d904 before opening the PR; no commit since base touches packages/spec/src/migrations/**, so no merge was needed). pnpm --filter @objectstack/spec build — clean, check-dts-emitted 36/36, check-dts-references 394/394 resolved. Positive control: grepped dist/index.js and dist/index.mjs for the new wording — 2 hits (one per entry); the old 'CurrencyConfigSchema.precision ... unchanged' sentence appears nowhere in dist. pnpm --filter @objectstack/spec test — 570 test files, 16741 tests passed, 1 todo, exit 0. pnpm --filter @objectstack/spec typecheck (tsc --noEmit + check:scripts-typecheck + check:test-typecheck) — exit 0; test-typecheck debt ledger unchanged (251 pre-existing pinned errors, shrink-only, none new). node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands, reconciled with --ran: 82 derived, 81 run/green, 1 NOT MEASURED (pnpm check:dual-build-cjs-loads — its own PREREQUISITE NOT MET, exit 3, names ~86 packages across the whole monorepo needing pnpm build first; this is the same population as ci.yml's 'Build Core' → 'Build packages' step, which dispatch-gates itself classifies as having no local invocation — full-tree build is CI's to run, disproportionate to this 3-file, zero-export/schema-shape diff). Two gates needed cheap, proportionate prerequisite builds before they could run for real, both then green: check:doc-formula-expressions (built @objectstack/formula + @objectstack/lint, then reran: exit 0) and check:lean-entry-closure (built @objectstack/objectql, then reran: exit 0, 'Admitted set held exactly (15 packages); 6 denied names absent'). All 82 gate exit codes captured before any pipe via a runner script writing one EXIT=N line per command.",
   "mcp_calls": "0 — no MCP tools of any kind were called at any point this round; all GitHub reads used plain curl, all GitHub writes went through scripts/pm/ (with-fleet.sh --via dispatch for pr_create and the os-dev-report comment, label-write.mjs for the PR assignee) per the card's ⛔ No MCP instruction.",
   "api_writes": "3 REST proxy writes, all via the fleet-write relay (objectstack-fleet[bot]): (1) POST /repos/objectstack-ai/objectstack/pulls (pr_create, draft forced) — opened PR #20488; (2) POST /repos//issues/20488/assignees (assign os-tesla) — read back confirmed, pre-existing labels (documentation, size/s, tooling) untouched, applied by other automation; (3) POST /repos//issues/20379/comments (this report). No labels beyond the PR assignee were written, per the card's write budget. git push (not a REST write, not counted) happened three times: the empty-branch probe, the implementation commit, and the changeset commit — none rejected.",
   "open_questions": [],
   "out_of_scope_findings": [
   "class: none (not filed) · reach: n/a · hypothesis-4 grep hit, resolved without action: packages/spec/CHANGELOG.md:13763 also pairs CurrencyConfigSchema.precision with 'unchanged', but it sits under the already-shipped ## 17.1.0 heading (the #8321 field-scale/precision entry) — release-frozen text per AGENTS.md Documentation Guardrails (never hand-edit CHANGELOG.md in a code PR), and it was true when published (major-18's retirement postdates 17.1.0). Not a defect, not touched. dedupe: CHANGELOG CurrencyConfigSchema.precision unchanged 17.1.0 stale",
   "carrier: none · noted, not filed · .changeset/19992-currency-config-precision-retired.md also contains the string 'unchanged' near precision, but it correctly refers to the FIELD-level precision (total digit count), not CurrencyConfigSchema.precision — no false claim, no action needed. dedupe: 19992 changeset field precision unchanged correct"
   ]
   }
8. objectstack-fleet commented on Sep 28, 2026

   

   objectstack-fleetbot

   on Sep 28, 2026

   ContributorAuthor

   More actions

   REWORK round 1 — PR #20488 at head db7ad5204f · domain:spec seat 2 (session_014EJ1ED8X4MMrT18BhVx4tx) · 2026-09-28T17:58Z

   The at-tier contract review 5875601370 on the PR returned FAIL for one reason. The seat re-measured it on origin/main and adopts it. The currency clause rewording, the regenerated registry, the patch level and Clause-②: no were judged right and do not change.

   • The item (sent to the same dev): the kept gantt clause in 18.ui-form-field-precision-scale-integer-refused.ts, 「The gantt scale enum is a different surface and is unchanged」, is false.
     • GanttConfigSchema (packages/spec/src/ui/view.zod.ts ~:1854, strictObject) declares no scale; its granularity key is viewMode: z.enum(['day','week','month','quarter','year']).
     • The only enum-valued scale is TimelineConfigSchema.scale (~:1418, 'hour' … 'year').
     • os migrate meta prints the sentence to authors, pointing them at a key a strict schema refuses.
   • Scope ruling (the seat's): the fix is in scope for this card. It is the same sentence this PR re-authors, in the same entry. Triage's 「keep the gantt scale clause, which is still true」 (5863776426) rested on a reading the code falsifies, so the seat corrects that execution note here instead of opening a sibling card for one clause. Name the surface that exists, the timeline view's scale enum (TimelineConfigSchema.scale), or drop the clause; then gen:migration-registry; no tracker number.
   • The landing now waits on: the round-1 head, a fresh at-tier record on that head, and every check green.

   ---

   Generated by Claude Code
9. objectstack-fleet commented on Sep 28, 2026

   

   objectstack-fleetbot

   on Sep 28, 2026

   ContributorAuthor

   More actions

   os-dev-report
   {
   "issue": 20379,
   "status": "done",
   "branch": "claude/issue-20379-currency-precision-d3-text",
   "pr": "#20488",
   "session": "session_014EJ1ED8X4MMrT18BhVx4tx",
   "premise_still_valid": true,
   "summary": "REWORK round 1, in response to the at-tier FAIL (5875601370) and the seat's rework note (5875625251). Re-read GanttConfigSchema and TimelineConfigSchema in packages/spec/src/ui/view.zod.ts myself: GanttConfigSchema (:1854, strictObject) declares no scale key at all — its granularity key is viewMode: z.enum(['day','week','month','quarter','year']); the only enum-valued scale is TimelineConfigSchema.scale (:1418, z.enum(['hour','day','week','month','quarter','year'])). The kept clause in 18.ui-form-field-precision-scale-integer-refused.ts, "The gantt scale enum is a different surface and is unchanged", was confirmed false — it names a key a strict schema refuses. Reworded it to name the surface that exists (TimelineConfigSchema.scale, still unchanged) and to say plainly the gantt view has no scale key. No tracker number added. Regenerated packages/spec/src/migrations/registry.ts with gen:migration-registry (diff mirrors only this one clause). Repo-wide grep for other author-shown text saying "gantt scale" found exactly 3 hits: the entry file (fixed), its generated mirror in registry.ts (fixed by regeneration), and this PR's own .changeset/20379-currency-precision-d3-text.md (updated — see below, not author-shown runtime text but corrected for accuracy). No other carrier anywhere in the repo. Added one paragraph to the changeset describing this second correction (still patch, Clause-②: no). Currency clause, patch level and Clause-②: no were judged right in the review and unchanged.",
   "tests": "HEAD 1cbd8ea52f (was db7ad5204f), merge-base 8e0285918 of origin/main. origin/main fetched at fc0db22bcf before finishing this round — 9 commits ahead of the base but none touch packages/spec/src/migrations/** (git log --oneline 8e02859185..origin/main -- packages/spec/src/migrations/ empty), so no merge was needed and os-regen-merge.sh was not invoked. Fresh, foreground, through os-verify-lock.sh: pnpm --filter @objectstack/spec run check:migration-registry — exit 0, 'src/migrations/registry.ts is current (310 semantic, 230 retired-key, 206 retired-def)'. The spec migrations tests, targeted: migrations.test.ts + spec-changes-surface-scope.test.ts + retired-tables-not-floor-scoped.test.ts under vitest project local — 3 files / 160 tests passed; retired-key-migrate-sentence.test.ts lives in vitest project repo (a toolchain trap the first run's own warning caught — 'FILTER SELECTED NOTHING'), reran correctly with --project repo — 1 file / 14 tests passed. pnpm check:doc-authoring — exit 0, 16703 customer-facing strings across 1166 spec sources clean, no internal issue-id references; sibling-package baseline unchanged (810 pinned sites, no growth). pnpm --filter @objectstack/spec typecheck (tsc --noEmit + check:scripts-typecheck + check:test-typecheck) — exit 0, same 251-error debt ledger, unchanged. Re-derived node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands on the new HEAD: same 82 derived families as round 1 (identical file surface, changed lines 37 (+29/-8)). Reconciled with --ran: 82 derived, 81 accounted green, 1 NOT MEASURED (pnpm check:dual-build-cjs-loads, same PREREQUISITE NOT MET as round 1 — needs a full ~86-package monorepo build, CI's Build Core job, unchanged reasoning). Of the 82, check:migration-registry and check:doc-authoring were re-measured fresh at this round's HEAD (both exit 0, above); the other 80 carry forward round 1's measurement at db7ad5204f, unchanged by this round's single-clause diff — stated plainly rather than implied.",
   "mcp_calls": "0 — no MCP tools of any kind were called at any point this round; all GitHub reads used plain curl, all GitHub writes went through scripts/pm/ (with-fleet.sh --via dispatch for the os-dev-report comment) per the card's ⛔ No MCP instruction.",
   "api_writes": "1 REST proxy write this round, via the fleet-write relay (objectstack-fleet[bot]): POST /repos//issues/20379/comments (this report). No PR body edit (⛔ dev never PATCHes a PR body — the coordinator's instructions named no body update, and the standard-clauses rule holds regardless), no label or assignee write this round (already set in round 1, coordinator named none this round). git push (not a REST write, not counted) happened once: the two-file rework commit 1cbd8ea52f, not rejected.",
   "open_questions": [],
   "out_of_scope_findings": [
   "class: none (not filed) · reach: n/a · repo-wide grep for "gantt scale" (step 2 of this round) found exactly 3 hits, all inside this card's own surface: the entry file (fixed this round), its generated mirror in packages/spec/src/migrations/registry.ts (fixed by gen:migration-registry), and this PR's .changeset/20379-currency-precision-d3-text.md (not author-shown runtime text, but updated for accuracy — see step 3). No other file in the repo, generated or hand-written, makes this claim. dedupe: gantt scale enum different surface unchanged false GanttConfigSchema viewMode",
   "class: none (not filed) · reach: n/a · carried from round 1, unchanged: packages/spec/CHANGELOG.md:13763 pairs CurrencyConfigSchema.precision with 'unchanged' under the already-shipped ## 17.1.0 heading — release-frozen text, true when published, not a defect.",
   "carrier: none · noted, not filed · carried from round 1, unchanged: .changeset/19992-currency-config-precision-retired.md's 'unchanged' correctly refers to the FIELD-level precision key, not CurrencyConfigSchema.precision — no false claim."
   ]
   }
10. objectstack-fleet commented on Sep 28, 2026

    

    objectstack-fleetbot

    on Sep 28, 2026

    ContributorAuthor

    More actions

    ACCEPT — PR #20488 at head 1cbd8ea52f (round 1) · domain:spec seat 2 (session_014EJ1ED8X4MMrT18BhVx4tx) · 2026-09-28T18:49Z

    The seat reviewed the dev reports 5875388171 (round 0) and 5876206709 (round 1) on this card against GitHub and the diff.

    • PR shape: draft, base main, first line Fixes #20379, the body's Clause-②: no line at line start, assignee os-tesla, 4 files (+29 / −8). The closing-keyword scan finds only #20379.
    • Diff, read by the seat:
      • Two reason literals in the major-18 D3 entries: the CurrencyConfigSchema.precision clause now says the key is retired in this same major by currency-config-precision-removed.
      • Round 1 corrects the form-field entry's gantt clause (the rework note 5875625251): it now names the timeline view's scale enum (TimelineConfigSchema.scale) and says the gantt view has no scale key (its granularity key is viewMode).
      • The generated registry mirror, and a patch changeset with Clause-②: no.
      • No key, schema, conversion or verdict moves.
    • At-tier contract review: round 0 5875601370 FAIL (the false gantt clause). Round 1 5876363774 PASS on this head, checked against the moved view.zod.ts on current main. It proves the registry byte-identical to a re-render from the entry files, and finds no other carrier of either false claim. The seat checked both transcripts: served at tier, read-only, one write each (the record).
    • Findings: packages/spec/CHANGELOG.md:13763 (under ## 17.1.0) is release-frozen and was true when published → dropped. .changeset/19992-*'s 「unchanged」 is about the field-level precision → dropped.
    • PR body: it still carried round 0's 「gantt clause … still true」 sentence and head. The seat corrects those two lines in place in the next act, so the squash commit does not repeat a claim the head removed.
    • Landing: CI green on the head (35 concluded: 32 success, 3 roster skips). This seat runs the pre-landing checks, flips it ready and arms auto-merge.

    ---

    Generated by Claude Code
11. objectstack-fleet

    closed this as completedin #20488on Sep 28, 2026
12. objectstack-fleet commented on Sep 28, 2026

    

    objectstack-fleetbot

    on Sep 28, 2026

    ContributorAuthor

    More actions

    Landing record — PR #20488 MERGED · domain:spec seat 2 (session_014EJ1ED8X4MMrT18BhVx4tx) · 2026-09-28T19:28Z

    • Merged through the merge queue at 2026-09-28T19:21Z as de8c973c17, after the ACCEPT 5876397336 and the round-1 at-tier PASS 5876363774.
    • Verified by content on origin/main de8c973c17, not by the merged flag: both D3 entry files, packages/spec/src/migrations/registry.ts and .changeset/20379-currency-precision-d3-text.md are blob-identical to the reviewed head 1cbd8ea52f; TimelineConfigSchema.scale is present in the registry mirror.
    • Closing: Fixes #20379 closed this card as completed; pm:dispatched is removed in this act (domain:*, area:* and type labels stay).

    ---

    Generated by Claude Code
13. objectstack-fleet

    removed

    pm:dispatched

    on Sep 28, 2026
14. veigajoao

    added 2 commits that reference this issue on Sep 29, 2026

    feat(objectql,spec)!: enforce a field's declared `precision` (total d…

    ...

    b98fbc2

    fix(spec): reword the CurrencyConfigSchema.precision clause in two ma…

    ...

    de8c973