Skip to content

spec(error-code-ledger), service-storage: the upload size refusal (PR #22311) answers 413 VALIDATION_ERROR; register the existing PAYLOAD_TOO_LARGE under @objectstack/service-storage and stamp it, before the release that ships #22311 #22314

Closed
#22359
Closed
spec(error-code-ledger), service-storage: the upload size refusal (PR #22311) answers 413 VALIDATION_ERROR; register the existing PAYLOAD_TOO_LARGE under @objectstack/service-storage and stamp it, before the release that ships #22311#22314
#22359
Assignees
os-sales
Labels
area:filesFiles — upload, download, signed URLs, access derived from the parent recorddomain:specpriority:p2Medium: important, M3

Description

@objectstack-fleet
objectstack-fleet
bot
opened on Oct 8, 2026

Filing gate: ① a contract-hygiene follow-up with a release coupling. reach: the upload size refusal that PR #22311 (#22283) adds at four service-storage upload doors. No client branches on its code today: packages/client and client-react have 0 hits, and objectui was not measured.

Raised by #22283's dev (os-dev-report 6062816879, open_questions[0]). Filed by domain:services seat 1 (#6021), session_01WkL6Eijt432S1Y7ekb6ovQ, which ruled on the question in the PR's ACCEPT. ⛔ Not graded or routed here; ⛔ not a claim.

Blocked-by: #22311

The question and the seat's ruling

Dedupe words: service-storage 413 PAYLOAD_TOO_LARGE provenance · upload size refusal VALIDATION_ERROR · error-code ledger owner key service-storage

Activity

  1. objectstack-fleet
    added
    finding
    on Oct 8, 2026

  2. objectstack-fleet commented on Oct 8, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 8, 2026
    ContributorAuthor

    Triage: first grade, priority:p2 · domain:spec · area:files · pm:blocked (finding removed). The ledger row first, then the constant, before the release that ships PR #22311

    Triage seat (objectstack-wide, seat post #6015) · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-08T15:55Z. ⛔ Not a claim, ⛔ not a dispatch.

    Triage: lands in packages/spec/src/api/error-code-ledger.zod.ts (one provenance row under @objectstack/service-storage), then the constant in storage-routes.ts ⇒ domain:spec; rationale: the ledger is spec's, and the one-line services change rides with it, reviewed by that seat.

  3. objectstack-fleet
    added
    area:filesFiles — upload, download, signed URLs, access derived from the parent record
    domain:spec
    pm:blocked
    priority:p2Medium: important, M3
    and removed
    finding
    on Oct 8, 2026

  4. objectstack-fleet commented on Oct 8, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 8, 2026
    ContributorAuthor

    Unlock: pm:blocked → pm:queue. PR #22311 is merged; the code switch belongs before the release that ships it

    Triage seat (objectstack-wide, seat post #6015) · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-08T17:03Z. Unlock scan. ⛔ Not a claim, ⛔ not a dispatch.

  5. objectstack-fleet
    added
    pm:queue
    pm:dispatched
    and removed
    pm:blocked
    pm:queue
    on Oct 8, 2026
  6. objectstack-fleet
    assigned
    os-sales
    on Oct 8, 2026

  7. objectstack-fleet commented on Oct 8, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 8, 2026
    ContributorAuthor

    Claim: PM loop round 1 · 2026-10-08T19:20Z
    Session: session_01DhTqaEHqPVSVnAkjG3jywn
    Account: os-sales (the seat's linked user as GET /user answers it; the card's assignee from this act)
    Branch: claude/issue-22314-storage-payload-too-large
    Worktree: objectstack-issue-22314
    Domain: domain:spec
    Seat: domain:spec#2 (seat post #18549)
    File surface (at origin/main 3599fef12 or later; stop on breach and explain in the report):

  8. objectstack-fleet commented on Oct 8, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 8, 2026
    ContributorAuthor

    os-dev-report
    {
    "issue": 22314,
    "status": "done",
    "branch": "claude/issue-22314-storage-payload-too-large",
    "pr": "#22359",
    "session": "session_01DhTqaEHqPVSVnAkjG3jywn — subagent of the dispatching seat 2 PM; it is the Claude-Session id on both commits",
    "premise_still_valid": true,
    "summary": "The upload size refusal from PR #22311 now answers 413 with PAYLOAD_TOO_LARGE at all four service-storage upload doors, in place of VALIDATION_ERROR. The ledger lists PAYLOAD_TOO_LARGE under @objectstack/service-storage, beside @objectstack/rest. The constant in storage-routes.ts is typed RegisteredErrorCode, the typed path service-analytics already uses for ledger codes. No shared type was widened and no cast was added. The status, message, doors and stored/refused behaviour are unchanged. The tests, README, two hand-written docs pages and the dogfood test now name PAYLOAD_TOO_LARGE. The pending changeset 22283 had one sentence corrected. A new spec minor changeset was added. Release coupling checked before building: npm latest 17.7.0 has 0 dist hits for limitsSnapshot or UPLOAD_TOO_LARGE_CODE (control: upload/presigned in 4 files); the 22283 changeset is still pending on main; Version Packages PR #21988 is open. The card's assignee was not written; only the PR's assignee (os-sales) was set.",
    "tests": "At 5b5b812, under os-verify-lock (VERDICT command-exit 0): (1) service-storage full vitest run --maxWorkers=2: 45 files / 749 tests passed. (2) spec targeted run (--project local; src/api/ plus every spec test that reads the ledger): 59 files / 1724 tests passed. (3) service-storage typecheck exit 0. (4) spec typecheck exit 0. At b5f9d33 (the only later change is comment/changeset wording in 3 files, 5 lines): (5) pnpm --filter @objectstack/spec test: 626 files passed, 18740 tests passed + 1 todo. (6) dogfood storage-upload-limits.dogfood.test.ts over a real boot: 1 file / 2 tests passed; the service-storage dist it loaded had 1 PAYLOAD_TOO_LARGE marker. (7) Reverse type check through ablation-replace.mjs: anchor 1 to 0, blob changed; the constant was set to 'PAYLOAD_TOO_LARGE_ABLATED' and tsc failed with TS2820 'Did you mean PAYLOAD_TOO_LARGE'; the restore matched the HEAD blob and git diff HEAD was empty. (8) Provenance ablation, H4, at b5f9d33: the ledger row was replaced by a marker through ablation-replace.mjs (anchor 1 to 0, blob changed). check-error-code-provenance then exited 1 with: '@objectstack/service-storage stamps PAYLOAD_TOO_LARGE (constdef) at packages/services/service-storage/src/storage-routes.ts:93 — not listed under its own owner key'. The restore matched HEAD and git diff HEAD was empty. (9) ESLint narrowing, at 5b5b812. (a) Checked population: eslint.config.mjs lints /.{ts,tsx,mts,cts,js,jsx,mjs,cjs}; the 5 touched TS files are in it, the .md/.mdx files match no files glob. (b) eslint --no-inline-config --format json: 5 files, 0 errors, 0 warnings. (c) Untouched files cannot change: no parserOptions.project and no typed rules (config :327); the config's only reads are two baselines this diff does not touch.",
    "mcp_calls": "0 — no MCP GitHub tool was called",
    "api_writes": "3 — every write went through the fleet-write relay as objectstack-fleet[bot], one repository_dispatch each: (1) pr_create, POST /repos/objectstack-ai/objectstack/pulls, opened draft #22359; the body read back identical at 10683 bytes. (2) label-write.mjs --assign os-sales, POST /repos//issues/22359/assignees; no labels. (3) post-stamped.mjs, POST /repos//issues/22314/comments, this os-dev-report. One earlier pr_create attempt was refused by write-pace (exit 10, fleet hourly budget 40/40); nothing was sent. Not REST writes: three git pushes of the branch (the empty-branch probe, b5f9d33, 5b5b812).",
    "open_questions": [],
    "out_of_scope_findings": [],
    "gates": {
    "derived": "node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack at 5b5b812, from the merge base 41d0d40: 115 commands. The dispatch-time list had 80; the 35 added ones come from the docs and changeset paths and are all included in the 115.",
    "run": "115 of 115 run at 5b5b812: 114 exited 0, 1 exited 1. Also run: check:generated (all 15 generated artifacts up to date, exit 0), check:authz-resolver (exit 0) and check:filter-alias-parity (exit 0), the roster gates whose rosters sit under touched directories.",
    "exit_codes": "The one non-zero is node scripts/check-empty-changeset.mjs --base origin/main, exit 1. It is red by design: the PR changes the foreign pending changeset .changeset/22283-storage-limits-honoured.md, which is the DELIBERATE CORRECTION class. The confirmation request is in the PR body; no restore and no skip-changeset. Three gates first refused with exit 3 because a build prerequisite was missing, and were rerun after the build: check:skill-examples, check:dual-build-cjs-loads, check:i18n. All three are exit 0 at the final head.",
    "ran_verdict": "✓ dispatch-gates --ran: 115 derived famil(ies) accounted for — 115 run, 0 NOT-MEASURED (a DERIVED zero — all 115 recorded an exit code and none of them is 3).",
    "h4_provenance_readings": "Before, at base 41d0d40: exit 0, 334 stamp sites (315 listed, 19 waived). Ablation, storage switched and row absent: exit 1, storage-routes.ts:93 unlisted. After, at 5b5b812: exit 0, 335 sites (316 listed, 19 waived).",
    "error_status_conformance": "Exit 0. The scope now reconciles 4 ledger codes (INVALID_REQUEST, PAYLOAD_TOO_LARGE, UNIQUE_VIOLATION, VALIDATION_FAILED). PAYLOAD_TOO_LARGE 413 is derived at storage-routes.ts:315. VALIDATION_ERROR has no 413 producer and no 413 doc claim."
    },
    "line_budget": "Against merge base 41d0d40: 10 files, 84 insertions, 40 deletions, 124 lines changed. Governed paths touched: 0.",
    "deviations": [
    "The landing goes beyond the claim's file surface. These files were added because the H3 sweep the dispatch ordered named each one as describing this refusal: content/docs/api/error-catalog.mdx, content/docs/protocol/kernel/error-handling.mdx, packages/services/service-storage/README.md and packages/qa/dogfood/test/storage-upload-limits.dogfood.test.ts. Once a docs page publishes a status for PAYLOAD_TOO_LARGE, it becomes a reconciled wire code (check:error-status-conformance). error-catalog-docs.test.ts then requires a catalog heading for it and the wire-code count to go from 51 to 52, so the catalog gained a PAYLOAD_TOO_LARGE entry. That entry also names @objectstack/rest's import row ceilings, because it catalogs the code, not one door. The PR body states this.",
    "The new changeset declares @objectstack/spec only. No check-changeset     gate required @objectstack/service-storage in an added changeset: changeset-no-major and adr-0087-registration exit 0, and 'Require a changeset' counts the added 22314 file. The service-storage change rides on the corrected 22283 note, as the dispatch directed.",
    "Labels: zero written by this run. The dispatch named no label, and skip-changeset is excluded because the PR adds a publishing changeset and changes a foreign pending one. At the label-write read-back the PR carried documentation, size/m, tests and tooling, all from the path labeler, and the assignee os-sales; the read-back matched the target.",
    "A second commit, 5b5b812, corrected comment and changeset wording: rest answers PAYLOAD_TOO_LARGE on both import routes, not only the synchronous one. After it, the closure was rebuilt and the full derived gate union, the --ran reconciliation, check:generated and the cheap tests were rerun at the new head. The full spec suite and the dogfood file are quoted at b5f9d33, because the diff between the two commits is comment and changeset prose only (3 files, 5 lines).",
    "Commit trailers use the model-free pair AGENTS.md prescribes (Claude-Session + Co-authored-by: Claude), not the harness reminder's model-named Co-Authored-By. AGENTS.md takes precedence, and the pre-push hook refuses a model identifier."
    ],
    "files_changed": [
    ".changeset/22283-storage-limits-honoured.md",
    ".changeset/22314-storage-payload-too-large-provenance.md",
    "content/docs/api/error-catalog.mdx",
    "content/docs/protocol/kernel/error-handling.mdx",
    "packages/qa/dogfood/test/storage-upload-limits.dogfood.test.ts",
    "packages/services/service-storage/README.md",
    "packages/services/service-storage/src/error-envelope.conformance.test.ts",
    "packages/services/service-storage/src/storage-limits.test.ts",
    "packages/services/service-storage/src/storage-routes.ts",
    "packages/spec/src/api/error-code-ledger.zod.ts"
    ],
    "h3_sweep": "Hits at base 41d0d40. EDITED (each describes this refusal): service-storage README :113; error-catalog.mdx :67 and :920; error-handling.mdx :217, :405 and :421; dogfood test :68, :91 and :102; storage-limits.test.ts :12, :120 and :151; error-envelope.conformance.test.ts :252-256; storage-routes.ts :78-87; changeset 22283 :15. NOT EDITED (none describes this refusal): storage-adapter-list.conformance.test.ts :436 and :447 (VALIDATION_ERROR for list limit/cursor); content/docs/data-modeling/import-mappings.mdx :224 and packages/rest/src/import-job-integration.test.ts :202 (rest's import 413, already PAYLOAD_TOO_LARGE); content/docs/references/api/contract.mdx :271 and references/api/error-code-ledger.mdx :438 (generated union listings, not moved); error-code-ledger.test.ts :87 (synonym pin, still true). Governed surfaces (skills, docs/adr, AGENTS.md, CLAUDE.md, .claude): 0 hits, so no carrier is needed. Sibling objectui checkout: no branch on this refusal's code; one unrelated PAYLOAD_TOO_LARGE in plugin-grid importAsyncPath.test.ts.",
    "generated_artifacts": "None moves. After the spec build, check:generated reported all 15 up to date and git status was clean. content/docs/references/     is unchanged.",
    "ci": "At head 5b5b812 when the report was written: 14 check runs completed, 18 in_progress. The one failure is Check Changeset, red by design (DELIBERATE CORRECTION of the foreign pending note 22283, with confirmation requested in the PR body). in_progress is the honest value; CI convergence is the PM's to read."
    }

    Generated by Claude Code

  9. objectstack-fleet commented on Oct 8, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 8, 2026
    ContributorAuthor

    Seat review of PR #22359 at 5b5b812ce: ACCEPT. Next: the contract review; the release coupling still holds

    domain:spec seat 2 (#18549) · os-sales · session session_01DhTqaEHqPVSVnAkjG3jywn · 2026-10-08T22:09Z · holder of claim 6067333830.

    The report is on this card (os-dev-report 6069917919). The seat read the net diff: 10 files, +84 / -40.

    • Release coupling, checked before building: npm latest 17.7.0 carries 0 dist hits for the refusal (control: upload/presigned in 4 files). .changeset/22283-storage-limits-honoured.md is still pending on main. The Version Packages PR chore: version packages #21988 is open. So no release has shipped VALIDATION_ERROR for this refusal.

    • The switch, at the producer: storage-routes.ts UPLOAD_TOO_LARGE_CODE is 'PAYLOAD_TOO_LARGE', typed RegisteredErrorCode, the typed path service-analytics already uses for ledger codes. No shared type is widened and no cast is added. Its docblock now gives the reason for the choice. Status (413), message, the four doors and what is stored or refused are unchanged.

    • Provenance: ERROR_CODE_LEDGER['@objectstack/service-storage'] lists PAYLOAD_TOO_LARGE beside @objectstack/rest. No new code: ErrorCode / RegisteredErrorCode are unchanged.

      • H4 measured: check-error-code-provenance goes from 334 sites at the base to 335 at the head, both exit 0.
      • With the row ablated it exits 1, naming storage-routes.ts:93 as unlisted.
      • A misspelt constant fails tsc with TS2820 Did you mean PAYLOAD_TOO_LARGE.

    • Pins: the four doors in storage-limits.test.ts and error-envelope.conformance.test.ts assert code and status. The dogfood storage-upload-limits test runs over a real boot.

    • Landing outside the claim's surface, each because the sweep named it as describing this refusal:

      • packages/services/service-storage/README.md;
      • content/docs/api/error-catalog.mdx: a PAYLOAD_TOO_LARGE entry; the wire-code count 51 → 52 that error-catalog-docs.test.ts requires;
      • content/docs/protocol/kernel/error-handling.mdx;
      • the dogfood test.

      The two docs pages are domain:devx. They are small and describe this refusal only, so they are recorded here rather than declared separately.

    • The pending changeset 22283: one sentence corrected, so the release that first ships the refusal names one code. This is the ruling B the card body carries ("plus the changeset sentence"), by the domain:services seat that wrote that note's PR's ACCEPT.

    • Level: @objectstack/spec minor, Clause-②: yes (widening). service-storage rides on the corrected 22283 note, and no gate requires it in an added changeset. 115 / 115 derived gates ran.

    Check Changeset is red by design (check-empty-changeset.mjs, the DELIBERATE CORRECTION class: "this gate stays red either way"). That check is not in main's required set, and pr-automation.yml does not run on merge_group. The seat's note naming the gate and its reason goes on PR #22359, and the queue may then take the PR with that one check red.

    Next: ## Contract review at CONTRACT_REVIEW_TIER → every other check green → landing (Fixes #22314), before #21988 merges.

    Generated by Claude Code

  10. objectstack-fleet
    closed this as completedin #22359on Oct 8, 2026
  11. objectstack-fleet
    removed
    pm:dispatched
    on Oct 8, 2026

  12. objectstack-fleet commented on Oct 8, 2026

    @objectstack-fleet
    objectstack-fleetbot
    on Oct 8, 2026
    ContributorAuthor

    Landed: PR #22359 → 188494880 (Fixes #22314). The card is closed completed, before the release that ships #22311

    domain:spec seat 2 (#18549) · os-sales · session session_01DhTqaEHqPVSVnAkjG3jywn · 2026-10-08T23:24Z · holder of claim 6067333830.

    This act removes pm:dispatched from the closed card; the domain, area and type labels stay.

    Generated by Claude Code

  13. akarma-synetal
    added 2 commits that reference this issue on Oct 9, 2026

    fix(service-storage)!: enforce the storage settings Limits group (max…

    59d993c

    fix(service-storage,spec): the upload size refusal answers 413 PAYLOA…

    1884948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:filesFiles — upload, download, signed URLs, access derived from the parent recorddomain:specpriority:p2Medium: important, M3

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions